On Tue, Jul 11, 2023 at 5:20 AM <alugowski@gmail.com> wrote:
Thanks for the support everyone, we now have a PR: https://github.com/scipy/scipy/pull/18631
I included a memory benchmark for those wondering about memory usage. The measured peak RSS is the same as the current Python version, except it's lower when writing coordinate matrices. This is because _mmio copies the values array, FMM does not.
Feedback welcome!
Thanks Adam, this looks pretty good! To everyone else: this is a fairly sizeable amount of C++ code which adds a little bit to our binary size (probably ~2%) and build time (probably ~8%), but the performance gains, extra features and better maintained code are probably worth it. I'm still reviewing and would like to get build time impact a little lower still; if anyone else is interested please weigh in though. Cheers, Ralf