Hi all,
I recently received some criticism for merging a PR that had only 1 commit and producing a single merge commit on top of it (this happens to be the default option I have/what I've been doing for years). See here:
https://github.com/scipy/scipy/pull/14630
I'd like to mention a few things here:
- are we still "ok" with folks doing this? frankly, I find taking heat for precise merging philosophy a bit unwelcoming even as someone who has been contributing for a while; sometimes it is important to squash 100 messy commits, but otherwise
do a good job reviewing PRs and relaxing on the purist "git history" attacks seem a bit more welcoming to me
- I find those merge commits somewhat useful when navigating back to GitHub anyway, maybe because I'm so used to them
- why does GitHub allow us to do this if it really isn't useful at all?
Tyler