I'm tentatively suggesting that we do a second release candidate, rc2, on or at least close to December 3rd. My notes currently show the PRs/ issues below on the "backport radar." In particular, I think Ralf noticed an API inconsistency in one of the big optimize enhancements. https://github.com/scipy/scipy/pull/9541 https://github.com/scipy/scipy/issues/9547 https://github.com/scipy/scipy/pull/9550 On Wed, 21 Nov 2018 at 15:07, Ralf Gommers <ralf.gommers@gmail.com> wrote:
On Wed, Nov 21, 2018 at 9:32 AM Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
I've pushed the v1.2.x wheels branch -- initially this will aim to confirm that SciPy master branch is now passing the Travis & Appveyor wheel builds.
If that is the case, I will proceed with the 3 connected backport PRs to the maintenance branch.
Then, I will point the v.1.2.x wheels branch to an appropriate commit on the patched maintenance branch for release candidate wheel builds.
Sounds like a plan!
Ralf
On Sat, 17 Nov 2018 at 10:27, Ilhan Polat <ilhanpolat@gmail.com> wrote:
Good stuff Tyler. I have to also add to that list the recent pypy3 run failures appearing sporadically (though consistent on my PRs).
I am trying triangulate the cause but probably will have to wait until at least tomorrow. Feedback is more than welcome. They seem to be related to cython/numpy versions but one can never be sure.
İlhan
On Fri, Nov 16, 2018, 19:35 Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
Current delays / issues I'm working on--feel free to chime in on those:
- a few test failures in wheel building matrix: https://github.com/MacPython/scipy-wheels/pull/37 - hard-to-understand putative patch for one of the failures: https://github.com/scipy/scipy/pull/9486
On Fri, 9 Nov 2018 at 08:40, Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
I branched 1.2.x around 8:30 am Pacific time on Nov. 9, 2018.
Working on the follow up master branch PR to bump version number / notes file, etc. now.
On Thu, 8 Nov 2018 at 22:49, Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
Release note PR is hopefully taking shape now -- I'll allow (another) delay for the branch until tomorrow (morning?) for some (hopefully final) checks on that.
On Thu, 8 Nov 2018 at 14:35, Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
> There are 0 remaining PRs with a 1.2.0 milestone. > > There is one issue left with a 1.2.0 milestone: > https://github.com/scipy/scipy/issues/9441 > > Please do take a look over the release notes WIP PR based on the > wiki: https://github.com/scipy/scipy/pull/9461 > > Target is to branch in 5-6 hours or so. Let me know if you see any > issues of course -- Ralf has been coaching > me through pretty well so far I think. > > On Wed, 7 Nov 2018 at 09:52, Ilhan Polat <ilhanpolat@gmail.com> > wrote: > >> Hang in there Tyler :) >> >> Awesome job so far. >> >> >> On Wed, Nov 7, 2018, 06:08 Ralf Gommers <ralf.gommers@gmail.com> >> wrote: >> >>> >>> >>> On Tue, Nov 6, 2018 at 9:03 PM Tyler Reddy < >>> tyler.je.reddy@gmail.com> wrote: >>> >>>> 7 PRs : >>>> https://github.com/scipy/scipy/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2.0 >>>> 3 issues: >>>> https://github.com/scipy/scipy/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.2... >>>> >>> >>> Awesome, getting there:) >>> >>> >>>> Target: branch sometime on November 8th >>>> >>>> On Mon, 5 Nov 2018 at 05:42, Tyler Reddy < >>>> tyler.je.reddy@gmail.com> wrote: >>>> >>>>> Alright, I'll extend to Thursday Nov. 8th & see if I can reduce >>>>> that list a bit >>>>> >>>>> On Sun, 4 Nov 2018 at 22:27, Ralf Gommers < >>>>> ralf.gommers@gmail.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, Oct 26, 2018 at 7:03 PM Mark Alexander Mikofski < >>>>>> mikofski@berkeley.edu> wrote: >>>>>> >>>>>>> Hi Tyler and others, >>>>>>> >>>>>>> Thanks for managing the v1.2 release. >>>>>>> >>>>>>> I think PR #8431, Cython optimize zeros API, is ready, >>>>>>> hopefully, to merge. It's been through several rounds of reviews and I >>>>>>> think I've accommodated all of the recommendations, all tests are passing, >>>>>>> and there's been strong support. Anyone please take a look. >>>>>>> >>>>>>> https://github.com/scipy/scipy/pull/8431 >>>>>>> >>>>>>> Thanks, >>>>>>> Mark >>>>>>> >>>>>>> On Fri, Oct 26, 2018, 2:38 PM Ralf Gommers < >>>>>>> ralf.gommers@gmail.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 25, 2018 at 12:55 PM Tyler Reddy < >>>>>>>> tyler.je.reddy@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> It is almost 6 months after the 1.1.0 release on May 5, so >>>>>>>>> probably time to plan the 1.2.0 release. It would be a good idea to look >>>>>>>>> over the PRs with a 1.2.0 milestone >>>>>>>>> <https://github.com/scipy/scipy/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2.0>, >>>>>>>>> and tag anything else that should have this milestone appropriately. >>>>>>>>> >>>>>>>>> I'd like to propose the following schedule: >>>>>>>>> >>>>>>>>> Nov. 5: branch 1.2.x >>>>>>>>> Nov. 8: rc1 >>>>>>>>> Nov. 21: rc2 (if needed) >>>>>>>>> Nov. 30: final release >>>>>>>>> >>>>>>>>> Thoughts? >>>>>>>>> >>>>>>>> >>>>>>>> This looks like a good schedule to me. We'll probably >>>>>>>> struggle to get some PRs marked for 1.2.0 merged, but that's always the >>>>>>>> case. >>>>>>>> >>>>>>> >>>>>> Hi Tyler, could we shift the branch date by 2-3 days (or up to >>>>>> a week)? There's a couple of PRs that I'd really like to see merged or >>>>>> decided on (for optimize and stats mainly), and there's right now still 18 >>>>>> open PRs marked for 1.2.0. >>>>>> >>>>>> A note on the open PRs: what we want to aim for is to have the >>>>>> list of open PRs and open blocking issues at zero, and have at most some >>>>>> non-blocking issues under the milestone left. Normally the release manager >>>>>> starts making those decisions, or pinging people, if other reviewers >>>>>> haven't done so in time. Of course it would be ideal if everyone has >>>>>> another look at >>>>>> https://github.com/scipy/scipy/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.2.0 >>>>>> and bumps or finished off PRs he/she is involved in. >>>>>> >>>>>> Cheers, >>>>>> Ralf >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> SciPy-Dev mailing list >>>>>> SciPy-Dev@python.org >>>>>> https://mail.python.org/mailman/listinfo/scipy-dev >>>>>> >>>>> _______________________________________________ >>>> SciPy-Dev mailing list >>>> SciPy-Dev@python.org >>>> https://mail.python.org/mailman/listinfo/scipy-dev >>>> >>> _______________________________________________ >>> SciPy-Dev mailing list >>> SciPy-Dev@python.org >>> https://mail.python.org/mailman/listinfo/scipy-dev >>> >> _______________________________________________ >> SciPy-Dev mailing list >> SciPy-Dev@python.org >> https://mail.python.org/mailman/listinfo/scipy-dev >> > _______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev