On Mon, Feb 22, 2021 at 3:43 PM Trever Hines <treverhines@gmail.com> wrote:
Hello all,
I have made a pull request here https://github.com/scipy/scipy/pull/13595, and I would appreciate any feedback.
Your PR looks really good, thanks for working on this Trever!
On Thu, Feb 4, 2021 at 7:23 PM Stefan van der Walt <stefanv@berkeley.edu> wrote:
Is there any advantage to keeping the old interface, or should this eventually replace Rbf entirely?
My intention is for `RBFInterpolator` to replace `Rbf` entirely. It should be possible to replicate the functionality of `Rbf` with `RBFInterpolator` (albeit with warnings when the interpolant may not be well-posed). `Rbf` is not currently deprecated in my PR, but I can make that change if you think it is appropriate.
It looks to me like deprecating Rbf is a good idea. However, it's best not to do it too quickly after introducing the replacement, because then you force users that want to be compatible with multiple versions of scipy to do: if scipy.__version__ >= 1.7.0: RBFInterpolator(...) else: Rbf(...) So I would suggest that in your open PR you add a note to the `Rbf` docstring saying something like "`Rbf` is legacy code, for new usage please use `RbfInterpolator` instead". Cheers, Ralf
-Trever _______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev