On Thu, Jul 7, 2022 at 8:58 PM Anirudh Dagar anirudhdagar6@gmail.com wrote:
Hi all,
I started working on adding *scipy.datasets* submodule and reviving the discussion around the deprecation of *scipy.misc* earlier this year with Ralf's help. Both the PRs are ready for review, and I'd request maintainers to have a look at them and share their thoughts on Github. SciPy Datasets are implemented using pooch https://github.com/fatiando/pooch, but the PR doesn't add pooch as a new dependency as discussed.
- Add scipy.datasets: https://github.com/scipy/scipy/pull/15607
- Deprecate scipy.misc: https://github.com/scipy/scipy/pull/15901
(probably clear enough and doesn't need any discussions)
Thanks for pushing this forward Anirudh! It looks about ready to go.
One thing to be done, fairly easy to address, is to move the datasets with separate repos into the SciPy org and update the links https://github.com/AnirudhDagar/scipy/blob/scipy-datasets/scipy/datasets/_registry.py#L14-L17 in the registry file. Currently, all of these are under https://github.com/scipy-datasets. Some follow-ups will include getting rid of the dataset files from the SciPy repo completely once the PR is approved and merged.
Moving those repos into the SciPy GitHub org seems indeed preferred, to ensure we can reuse our normal permissions management workflow, and don't have to maintain duplicate sets of permissions. There will be quite a few repos over time, however given that they're named `dataset-xxx` I don't see an issue with that.
I plan to move these repos sometime next week. If anyone has a concern, please let me know.
Cheers, Ralf
Just wanted to bring up the updates on the mailing list. Please let me know if you have any kind of feedback on Github. Thanks!
Best, Anirudh
On Fri, Feb 25, 2022 at 3:58 PM Ralf Gommers ralf.gommers@gmail.com wrote:
On Wed, Feb 23, 2022 at 10:11 PM Stephan Hoyer shoyer@gmail.com wrote:
On Tue, Feb 22, 2022 at 9:20 PM Ralf Gommers ralf.gommers@gmail.com wrote:
If we were to keep them in SciPy, they might belong in scipy.optimize
next to check_grad and approx_frime. But I don't think these functions (as written) are very useful. They have obvious computational inefficiencies and very limited functionality. I would rather point users to a fully functioning library for finite-differences like findiff: https://github.com/maroba/findiff
Thanks Stephan! I didn't hear about findiff before. Would you recommend it over https://github.com/pbrod/numdifftools?
I haven't used either of them, it just came up in a search for finite differences in Python.
Okay, thanks Stephan. Both look good, so unless someone has practical experience and can make a recommendation for why one of these is preferred, we should probably list both in the deprecation notice.
Cheers, Ralf
SciPy-Dev mailing list -- scipy-dev@python.org To unsubscribe send an email to scipy-dev-leave@python.org https://mail.python.org/mailman3/lists/scipy-dev.python.org/ Member address: anirudhdagar6@gmail.com
SciPy-Dev mailing list -- scipy-dev@python.org To unsubscribe send an email to scipy-dev-leave@python.org https://mail.python.org/mailman3/lists/scipy-dev.python.org/ Member address: ralf.gommers@gmail.com