On Fri, Dec 7, 2018 at 1:15 AM Ralf Gommers <ralf.gommers@gmail.com> wrote:


On Mon, Dec 3, 2018 at 12:41 PM Sourav Singh <ssouravsingh12@gmail.com> wrote:

1) Would it be fine if I create a PR to SciPy's codebase to adopt pocketfft? The PR could give me an understanding of how to contribute to SciPy's fftpack module.

I would prefer to wait a little bit with that. The branching of 1.16.x in the NumPy repo is imminent (1-3 weeks I expect), and at that point Pocketfft can be merged into NumPy. Then we'll be able to have a discussion with the author, and port things to SciPy. I think having two PRs for Pocketfft integration going on in parallel is a bit much and likely will lead to duplicate work.

If you want to try your hand on something in fftpack now, this is probably the best choice of all the open issues: https://github.com/scipy/scipy/issues/5986#issuecomment-313889128


I think the suggested SciPy issue above is a good one.

Last week I rebased the real-to-real transforms PR in pyFFTW on current master so it is up to date and ready for continued work. There are still a few open items in the checklist at https://github.com/pyFFTW/pyFFTW/pull/256 if you are interested. However, as your project would be under SciPy, I think your time is probably better spent working on a SciPy PR such as the one Ralph suggested.