Hi, Just a quick comment on pull request workflow on scipy: - there's a "needs-work" label for PRs that have specific actionable changes required before OK for merging - there's a "needs-decision" label for PRs that are stalled on a design decision Unfortunately, Github UI does not indicate when new commits are added to PRs, potentially invalidating the "needs-work" label. It's also unrealistic to expect that the ~30 mails Github spews daily are read through and the labels updated manually. Luckily, with some scripting the relevant information on PRs with new commits and the labeling times can be retrieved from Github API. There's an automatic list here, provided on an as-is basis: https://pav.iki.fi/scipy-needs-work/ (Currently there are none, since I just went through them.) -- Pauli Virtanen
On Thu, Feb 18, 2016 at 2:31 PM, Pauli Virtanen <pav@iki.fi> wrote:
Hi,
Just a quick comment on pull request workflow on scipy:
- there's a "needs-work" label for PRs that have specific actionable changes required before OK for merging
- there's a "needs-decision" label for PRs that are stalled on a design decision
Unfortunately, Github UI does not indicate when new commits are added to PRs, potentially invalidating the "needs-work" label. It's also unrealistic to expect that the ~30 mails Github spews daily are read through and the labels updated manually.
Luckily, with some scripting the relevant information on PRs with new commits and the labeling times can be retrieved from Github API. There's an automatic list here, provided on an as-is basis: https://pav.iki.fi/scipy-needs-work/ (Currently there are none, since I just went through them.)
Quite useful, thanks Pauli! Ralf
participants (2)
-
Pauli Virtanen -
Ralf Gommers