Pull request #4648
Hi, I was wondering if there's anything else I could improve on for the pull request #4688 <https://github.com/scipy/scipy/pull/4648> (Fixes #4408: Vector-valued constraints in minimize() et al). It's still marked as "needs-work", although I followed all the things that Pauli Virtanen suggested. I'm a new contributor to SciPy so I'm not sure what the process is at this stage :). Should I just wait for it to be reviewed and merged, or is there anything else I should do? Thanks! Andreea
On Tue, Mar 31, 2015 at 4:34 AM, Andreea Georgescu < andreea.i.georgescu@gmail.com> wrote:
Hi,
I was wondering if there's anything else I could improve on for the pull request #4688 <https://github.com/scipy/scipy/pull/4648> (Fixes #4408: Vector-valued constraints in minimize() et al). It's still marked as "needs-work", although I followed all the things that Pauli Virtanen suggested. I'm a new contributor to SciPy so I'm not sure what the process is at this stage :). Should I just wait for it to be reviewed and merged, or is there anything else I should do?
You did everything right (including pinging this list if review takes too long). Denis just merged your PR. Thanks for this contribution, and keep them coming! Cheers, Ralf
Awesome, thank you! :)
On Apr 4, 2015, at 6:55 AM, Ralf Gommers <ralf.gommers@gmail.com> wrote:
On Tue, Mar 31, 2015 at 4:34 AM, Andreea Georgescu <andreea.i.georgescu@gmail.com> wrote: Hi,
I was wondering if there's anything else I could improve on for the pull request #4688 (Fixes #4408: Vector-valued constraints in minimize() et al). It's still marked as "needs-work", although I followed all the things that Pauli Virtanen suggested. I'm a new contributor to SciPy so I'm not sure what the process is at this stage :). Should I just wait for it to be reviewed and merged, or is there anything else I should do?
You did everything right (including pinging this list if review takes too long). Denis just merged your PR. Thanks for this contribution, and keep them coming!
Cheers, Ralf
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
participants (2)
-
Andreea Georgescu -
Ralf Gommers