Hi everyone, I have been recently working on using black on our code base. I have created this PR https://github.com/scipy/scipy/pull/14330 <https://github.com/scipy/scipy/pull/14330>. There are lots of points, hence I invite you to come over and comment directly instead of replying to this email. Thanks in advance for having a look, I hope we can make this work together! Cheers, Pamphile
On Thu, Jul 1, 2021 at 8:14 AM Pamphile Roy <roy.pamphile@gmail.com> wrote:
Hi everyone,
I have been recently working on using black on our code base.
I have created this PR https://github.com/scipy/scipy/pull/14330. There are lots of points, hence I invite you to come over and comment directly instead of replying to this email.
Thanks in advance for having a look, I hope we can make this work together!
The main one I don't like at all are dedented closing parenthesis and brackets. They don't look like python code blocks at all to me. When I looked at black a while ago, I gave up when I saw those. Josef
Cheers, Pamphile _______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev
On 01.07.2021, at 14:52, josef.pktd@gmail.com wrote:
The main one I don't like at all are dedented closing parenthesis and brackets. They don't look like python code blocks at all to me.
Seems strange, but less so after reading at this https://lukasz.langa.pl/1d1a43c4-9c8a-4c5f-a366-7f22ce6a49fc/ <https://lukasz.langa.pl/1d1a43c4-9c8a-4c5f-a366-7f22ce6a49fc/> . TL;DR it minimizes diffs among other advantages. Feel free to comment on the PR itself. Cheers, Pamphile
Hi everyone, The PR highlighted the need for a proper mathematical style guide. Tools like Black can only work if we are talking the same language. Hence, I have created the following issue https://github.com/scipy/scipy/issues/14354 <https://github.com/scipy/scipy/issues/14354> Thank you everyone for the discussions. I hope we can craft something to solve this issue. It would be great for the Python Scientific community in general. Cheers, Pamphile
On 01.07.2021, at 14:14, Pamphile Roy <roy.pamphile@gmail.com> wrote:
Hi everyone,
I have been recently working on using black on our code base.
I have created this PR https://github.com/scipy/scipy/pull/14330 <https://github.com/scipy/scipy/pull/14330>. There are lots of points, hence I invite you to come over and comment directly instead of replying to this email.
Thanks in advance for having a look, I hope we can make this work together!
Cheers, Pamphile
participants (2)
-
josef.pktd@gmail.com -
Pamphile Roy