Hi all, there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some memory leaks for me. It saves me from the need to frequently restart my remote processing scripts, that use ckdtrees, and otherwise leak memory like a sieve... May I humbly request - as just a user who knows his place - this to be merged? Best, Vincent Schut.
Dear Vincent, I'm very happy to hear that the code has helped you. The pull request is almost ready (I wrote most of it), and I've been delinquent in putting together the last few finishing touches so that it can be considered for a merge (rolling in some benchmarking code and merging a few final contributed fixes). Other than those, the code is ready to go. I've been very busy over the past few weeks, but will do my best to get these last issues sorted out soon. All the best, Patrick On Mon, Sep 3, 2012 at 1:32 PM, Vincent Schut <schut@sarvision.nl> wrote:
Hi all,
there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some memory leaks for me. It saves me from the need to frequently restart my remote processing scripts, that use ckdtrees, and otherwise leak memory like a sieve... May I humbly request - as just a user who knows his place - this to be merged?
Best, Vincent Schut.
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
On 09/03/12 14:37, Patrick Varilly wrote:
Dear Vincent,
I'm very happy to hear that the code has helped you. The pull request is almost ready (I wrote most of it), and I've been delinquent in putting together the last few finishing touches so that it can be considered for a merge (rolling in some benchmarking code and merging a few final contributed fixes). Other than those, the code is ready to go. I've been very busy over the past few weeks, but will do my best to get these last issues sorted out soon.
All the best,
Patrick
Hi Patrick, thanks, sounds good! I can confirm that for me the code works, and the memory leaks are gone. As I will soon need to install my processing software on some new cluster computers, and I prefer to be able to just install scipy from the main repo instead of having to merge it with Sturla's and yours, that's why I asked. I have added myself as a watcher to your PR, so I suppose I should get informed automatically now when something changes or the PR gets merged. Thanks (also to Sturla) for the good work! Best, Vincent.
On Mon, Sep 3, 2012 at 1:32 PM, Vincent Schut <schut@sarvision.nl <mailto:schut@sarvision.nl>> wrote:
Hi all,
there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some memory leaks for me. It saves me from the need to frequently restart my remote processing scripts, that use ckdtrees, and otherwise leak memory like a sieve... May I humbly request - as just a user who knows his place - this to be merged?
Best, Vincent Schut.
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org <mailto:SciPy-Dev@scipy.org> http://mail.scipy.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
On 03.09.2012 14:47, Vincent Schut wrote:
thanks, sounds good! I can confirm that for me the code works, and the memory leaks are gone.
That is good to hear :) The cKDTree code in SciPy master has a few places where I expected that memory leaks could occur (particularly if there were exceptions) or integers could overflow (particularly on Win64). I removed all that I could see (there might still be more bugs, though), we and tried not to introduce any in Patrick's new code. Sturla
On Mon, Sep 3, 2012 at 2:47 PM, Vincent Schut <schut@sarvision.nl> wrote:
On 09/03/12 14:37, Patrick Varilly wrote:
Dear Vincent,
I'm very happy to hear that the code has helped you. The pull request is almost ready (I wrote most of it), and I've been delinquent in putting together the last few finishing touches so that it can be considered for a merge (rolling in some benchmarking code and merging a few final contributed fixes). Other than those, the code is ready to go. I've been very busy over the past few weeks, but will do my best to get these last issues sorted out soon.
All the best,
Patrick
Hi Patrick,
thanks, sounds good! I can confirm that for me the code works, and the memory leaks are gone. As I will soon need to install my processing software on some new cluster computers, and I prefer to be able to just install scipy from the main repo instead of having to merge it with Sturla's and yours, that's why I asked. I have added myself as a watcher to your PR, so I suppose I should get informed automatically now when something changes or the PR gets merged.
Thanks (also to Sturla) for the good work!
This PR is merged now. Thanks Patrick and Sturla! Ralf
On Mon, Sep 3, 2012 at 1:32 PM, Vincent Schut <schut@sarvision.nl <mailto:schut@sarvision.nl>> wrote:
Hi all,
there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some
memory
leaks for me. It saves me from the need to frequently restart my
remote
processing scripts, that use ckdtrees, and otherwise leak memory
like a
sieve... May I humbly request - as just a user who knows his place - this to be merged?
Best, Vincent Schut.
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org <mailto:SciPy-Dev@scipy.org> http://mail.scipy.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
We are waiting for Pat Varilly to merge the last fix I did for Windows 64 (it has weird integer size issues) into his branch. He has not replied in several weeks, so maybe I should open a new PR? Sturla On 03.09.2012 14:32, Vincent Schut wrote:
Hi all,
there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some memory leaks for me. It saves me from the need to frequently restart my remote processing scripts, that use ckdtrees, and otherwise leak memory like a sieve... May I humbly request - as just a user who knows his place - this to be merged?
Best, Vincent Schut.
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
Never mind this, I didn't see Patrick's reply. On 04.09.2012 13:39, Sturla Molden wrote:
We are waiting for Pat Varilly to merge the last fix I did for Windows 64 (it has weird integer size issues) into his branch. He has not replied in several weeks, so maybe I should open a new PR?
Sturla
On 03.09.2012 14:32, Vincent Schut wrote:
Hi all,
there is this pull request with improvements for ckdtree (https://github.com/scipy/scipy/pull/262) that fixes quite some memory leaks for me. It saves me from the need to frequently restart my remote processing scripts, that use ckdtrees, and otherwise leak memory like a sieve... May I humbly request - as just a user who knows his place - this to be merged?
Best, Vincent Schut.
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
_______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
participants (4)
-
Patrick Varilly -
Ralf Gommers -
Sturla Molden -
Vincent Schut