Re: [SciPy-Dev] removing the Lena image
My only concern is that existing code might rely on being able to invoke an image with this command. Then, rather than depreciate and remove, why don't we replace the image. After some discussion here, I think the best candidate would be an image of a cat. There are enough pictures of cats available to select one with identical dimensions and similar color characteristics. On Aug 15, 2015 8:40 AM, "Matthew Brett" <matthew.brett@gmail.com> wrote:
On Sat, Aug 15, 2015 at 5:03 PM, Cantwell Carson <carsonc@gmail.com> wrote:
My only concern is that existing code might rely on being able to invoke an image with this command.
That will be the case. Example: http://scipy-lectures.github.io/advanced/image_processing/index.html
Then, rather than depreciate and remove, why don't we replace the image.
I think that's worse than an exception. An exception will be visible and people can fix their code. Silently returning a different image may go undetected. Ideally we'd have a release with a deprecation warning and then remove the function in the release after that, however in this case the extra 6-8 months may become an issue. Given that the impact will probably not be very large (it's mostly examples and not people's production/research code that will break), I'm in favor of removing it straight away. Ralf
Ralf Gommers <ralf.gommers@gmail.com> wrote:
I think that's worse than an exception. An exception will be visible and people can fix their code. Silently returning a different image may go undetected.
Yes, returning an image of a cat is certainly unacceptable. It should return the IEEE Lena test image or raise an error. Sturla
On Sat, Aug 15, 2015 at 5:02 PM, Sturla Molden <sturla.molden@gmail.com> wrote:
Ralf Gommers <ralf.gommers@gmail.com> wrote:
I think that's worse than an exception. An exception will be visible and people can fix their code. Silently returning a different image may go undetected.
Yes, returning an image of a cat is certainly unacceptable. It should return the IEEE Lena test image or raise an error.
Although I think that would be humorous, I can see why it would not be a good idea. My suggestion then is to remove Lena and provide an exception suggesting an alternative command, perhaps scipy.misc.cat. I will even go so far as to suggest a specific image of a cat, as used in the zhanxw's cat project <https://github.com/zhanxw/cat/blob/master/cat.jpg>. This returns the desired error, but retains the convenience that the previous image provided.
participants (3)
-
Cantwell Carson -
Ralf Gommers -
Sturla Molden