There are two tickets that contain donated code, which have been sitting around for over a year or more: http://scipy.org/scipy/scipy/ticket/354 http://scipy.org/scipy/scipy/ticket/457 I would like to see at least some comments on them about why they haven't been accepted. They are both first attempts but no one has made any critical comments or useful suggestions for what the authors need to do in order to have their code accepted. One provides support the Harwell-Boeing format and the other provides a FIR filter. For instance, would someone be willing to take a look and add a comment to the ticket that addresses at least: Do they need tests and coding style work? Or is there no interest in including this code in scipy? Thanks, -- Jarrod Millman Computational Infrastructure for Research Labs 10 Giannini Hall, UC Berkeley phone: 510.643.4014 http://cirl.berkeley.edu/
On Wed, Nov 26, 2008 at 10:31 PM, Jarrod Millman <millman@berkeley.edu> wrote:
I would like to see at least some comments on them about why they haven't been accepted. They are both first attempts but no one has made any critical comments or useful suggestions for what the authors need to do in order to have their code accepted. One provides support the Harwell-Boeing format and the other provides a FIR filter.
For instance, would someone be willing to take a look and add a comment to the ticket that addresses at least: Do they need tests and coding style work? Or is there no interest in including this code in scipy?
Harwell-Boeing support would be useful, and the attached code is well-written. We'll need some tests, but that's not too difficult. I'll see that this gets added to SciPy 0.8. -- Nathan Bell wnbell@gmail.com http://graphics.cs.uiuc.edu/~wnbell/
Nathan Bell wrote:
On Wed, Nov 26, 2008 at 10:31 PM, Jarrod Millman <millman@berkeley.edu> wrote:
I would like to see at least some comments on them about why they haven't been accepted. They are both first attempts but no one has made any critical comments or useful suggestions for what the authors need to do in order to have their code accepted. One provides support the Harwell-Boeing format and the other provides a FIR filter.
For instance, would someone be willing to take a look and add a comment to the ticket that addresses at least: Do they need tests and coding style work? Or is there no interest in including this code in scipy?
Harwell-Boeing support would be useful, and the attached code is well-written. We'll need some tests, but that's not too difficult.
I'll see that this gets added to SciPy 0.8.
While we're at it, what about #713? http://www.scipy.org/scipy/scipy/ticket/713
2008/11/27 Jarrod Millman <millman@berkeley.edu>:
There are two tickets that contain donated code, which have been sitting around for over a year or more: http://scipy.org/scipy/scipy/ticket/354 http://scipy.org/scipy/scipy/ticket/457
I would like to see at least some comments on them about why they haven't been accepted. They are both first attempts but no one has made any critical comments or useful suggestions for what the authors need to do in order to have their code accepted. One provides support the Harwell-Boeing format and the other provides a FIR filter.
Do you know if the author of the FIR filter code ("tash") is still around? If we can verify that the code does what it is supposed to, I think this would make a good addition to SciPy. Regards Stéfan
participants (4)
-
Jarrod Millman -
Nathan Bell -
Stéfan van der Walt -
Yosef Meller