Hello, I opened the issue #10011 <https://github.com/scipy/scipy/issues/10011> about wrong validation of rotation plane axes in the ndimage.interpolation.rotate function. I also made some propositions for refactoring this function. You can see my contribution in the pull request #10028 <https://github.com/scipy/scipy/pull/10028>. This is my first time filling a pull request for Scipy, so I hope that every thing is OK with it. Thank you for your review and comments, Riadh.
On Mon, Apr 8, 2019 at 11:36 AM Riadh <rfezzani@gmail.com> wrote:
Hello,
I opened the issue #10011 <https://github.com/scipy/scipy/issues/10011> about wrong validation of rotation plane axes in the ndimage.interpolation.rotate function.
I also made some propositions for refactoring this function. You can see my contribution in the pull request #10028 <https://github.com/scipy/scipy/pull/10028>.
This is my first time filling a pull request for Scipy, so I hope that every thing is OK with it.
This all looked really good, thanks Riadh Cheers, Ralf
Thank you for your review and comments,
Riadh. _______________________________________________ SciPy-Dev mailing list SciPy-Dev@python.org https://mail.python.org/mailman/listinfo/scipy-dev
participants (2)
-
Ralf Gommers -
Riadh