PR for signal.planck (Planck-taper and Planck-Bessel window functions)
Hi everyone, I'd like to bring to your attention this PR: https://github.com/scipy/scipy/pull/6012 which implements the Plack-taper window (http://arxiv.org/pdf/1003.2939) along with tests and documentation. It's a rarely-used window, with current citations only in the gravitational-wave field of research. I can definitely see why there might be reluctance in merging such a rarely used window. Nevertheless, I'd like to know if there is actual interesting or not, as I could furthermore provide the implementation of the Planck-Bessel and Cosine-Hyperbolic windows as well. Thanks!
On Sat, Apr 09 2016, Yuri D'Elia wrote:
I'd like to bring to your attention this PR:
https://github.com/scipy/scipy/pull/6012
which implements the Plack-taper window (http://arxiv.org/pdf/1003.2939) along with tests and documentation.
Hrrrm, I should have said: Gravitational Research @ Home Drive the LIGO with Pythonⓡ or... All the windows you need! Pull one, get two! But seriously, these are seldomly used windows yes. The only issue I see is that sp.signal might not be the best namespace to put them in. What about having a proper namespace for window generators (sp.signal.window) instead, leaving the old ones as aliases for backward compatibility? We do have get_window(), which is the perfect generic entry point. If the window has been used and cited in the literature, I'd personally like to have it available.
participants (1)
-
Yuri D'Elia