Hi all, My PR which enables the line-length check in the linter package-wide is passing CI and ready for review. In order to do this, I have cleaned up existing violations of the documented 88 character limit. https://github.com/scipy/scipy/pull/19609 If there is any part of the source code in which you care about style, please give the PR a look or comment that you would like to when you have time. The diff is too large for any one maintainer to review in detail, so a bit of a team effort would be ideal. I have split the changes for each submodule into separate commits. The reason for doing this work now is *not* that trivial style changes are a good use of reviewer time (I am aware that they are not). Rather, since it is unreasonable to expect reviewers to manually check line-length in PRs, we want this to be done by the linter. The longer we wait to do this work, the more difficult it will become as more violations will creep in. It also makes it much easier for new contributions to comply with the limit when all of the surrounding code does too. Let’s get this done now before it becomes more difficult. Once people are given the time to take a look if they would like to, hopefully we can follow Ralf’s advice from gh-19479 by:
not trying to review / second-guess every single decision on individual lines. If it's overall a significant improvement and CI is green, just merge it.
Cheers, Lucas P.S. the PR also reduces us to a smaller set of `per-file-ignores`, with only the following files getting special treatment from the linter: [per-file-ignores] "**/__init__.py" = ["E402", "F401", "F403", "F405"] "scipy/linalg/lapack.py" = ["F405"] "scipy/stats/tests/data/_mvt.py" = ["E501", "E701", "E702"] # E501 (line length) ignores "scipy/constants/_codata.py" = ["E501"] "scipy/linalg/_cython_signature_generator.py" = ["E501"] "scipy/linalg/_generate_pyx.py" = ["E501"] "scipy/spatial/transform/_rotation.pyi" = ["E501"]
participants (1)
-
Lucas Colley