Hello, I have had comments from a few people over the last two months on the Ball Tree code that I submitted (ticket 1048). I cleaned up the code a bit and posted the changes on the tracker. Any other comments would be appreciated! -Jake
Jake VanderPlas wrote:
Hello, I have had comments from a few people over the last two months on the Ball Tree code that I submitted (ticket 1048). I cleaned up the code a bit and posted the changes on the tracker. Any other comments would be appreciated! -Jake _______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
Hi!. I'm not a scipy dev, but I'm very interested in your code. I'll take a look at it in the following days and give some feedback. Regards, ~fabian
Jake VanderPlas wrote:
Hello, I have had comments from a few people over the last two months on the Ball Tree code that I submitted (ticket 1048). I cleaned up the code a bit and posted the changes on the tracker. Any other comments would be appreciated! -Jake _______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org http://mail.scipy.org/mailman/listinfo/scipy-dev
Hi! Your code works great, with impressive speed improvements in high dimensions. I could just find a minor thing: leaf_size in the docstring should read leafsize. If this turns out to be too specific for scipy, would you mind that it get's included in scikit.learn [1] (BSD-license)? Thanks, fabian [1] http://scikit-learn.sourceforge.net
participants (2)
-
Fabian Pedregosa -
Jake VanderPlas