Hello, I've attached patches against the current cvs source for fftw3 support in scipy. I've only tested these under x86 *nix (debian with various combinations of fftw-dev and fftw3-dev installed). Could a few people please try the patches and send build feedback? fft-c-source.diff is diff'ed against the c source/header files in Lib/fftpack/src and system_info.diff is diff'ed against the build detection code in scipy_core/scipy_distutils/system_info.py -Matt Fishburn
Matt Fishburn wrote:
Hello,
I've attached patches against the current cvs source for fftw3 support in scipy. I've only tested these under x86 *nix (debian with various combinations of fftw-dev and fftw3-dev installed). Could a few people please try the patches and send build feedback?
Did anyone have a look at these patches? The code seems fine to me, and initial testing on my box looks OK, but I'd love to hear from someone else before committing this. One problem with scipy has always been the lack of contributors: we really need to heed when users are willing to send in patches, or else they'll never come back... I can commit this stuff, but I'd like to have at least another pair of eyeballs go over it at least once. Or just tell me to go ahead, I guess :) I just don't want to discourage Matt from contributing in the future. Cheers, f
Hi, I have tested the patches against scipy cvs from 5 days ago and they seem to be absolutely fine. My tests were all on Fedora Core 4 with gcc 4.0. Matt, thanks for the patches - I can finally get rid of fftw 2 which was long ago replaced in all my other production code. Regards, Ravi On Sunday 17 July 2005 23:32, Fernando Perez wrote:
Matt Fishburn wrote:
Hello,
I've attached patches against the current cvs source for fftw3 support in scipy. I've only tested these under x86 *nix (debian with various combinations of fftw-dev and fftw3-dev installed). Could a few people please try the patches and send build feedback?
Did anyone have a look at these patches? The code seems fine to me, and initial testing on my box looks OK, but I'd love to hear from someone else before committing this.
One problem with scipy has always been the lack of contributors: we really need to heed when users are willing to send in patches, or else they'll never come back... I can commit this stuff, but I'd like to have at least another pair of eyeballs go over it at least once. Or just tell me to go ahead, I guess :) I just don't want to discourage Matt from contributing in the future.
Cheers,
f
_______________________________________________ Scipy-dev mailing list Scipy-dev@scipy.net http://www.scipy.net/mailman/listinfo/scipy-dev
Ravikiran Rajagopal wrote:
Hi, I have tested the patches against scipy cvs from 5 days ago and they seem to be absolutely fine. My tests were all on Fedora Core 4 with gcc 4.0. Matt, thanks for the patches - I can finally get rid of fftw 2 which was long ago replaced in all my other production code.
Thanks for double checking, I'll take care of this later. Cheers, f
Matt Fishburn wrote:
Hello,
I've attached patches against the current cvs source for fftw3 support in scipy. I've only tested these under x86 *nix (debian with various combinations of fftw-dev and fftw3-dev installed). Could a few people please try the patches and send build feedback?
fft-c-source.diff is diff'ed against the c source/header files in Lib/fftpack/src and system_info.diff is diff'ed against the build detection code in scipy_core/scipy_distutils/system_info.py
I also ran a test on this and it worked fine for me. Committed to CVS. Thanks, Matt. Best, f
On Thu, 21 Jul 2005, Fernando Perez wrote:
Matt Fishburn wrote:
Hello,
I've attached patches against the current cvs source for fftw3 support in scipy. I've only tested these under x86 *nix (debian with various combinations of fftw-dev and fftw3-dev installed). Could a few people please try the patches and send build feedback?
fft-c-source.diff is diff'ed against the c source/header files in Lib/fftpack/src and system_info.diff is diff'ed against the build detection code in scipy_core/scipy_distutils/system_info.py
I also ran a test on this and it worked fine for me.
Are you sure that you ran the tests against scipy.fftpack with fftw3 support? There were few bugs that caused some unittests to fail. The bugs are now fixed but it would be nice if new patches would not break the scipy tests in future (though it's a clever way to get attention:). Matt, thanks for sending the patches. Fernando, thanks for making sure that patches were applied. Regards, Pearu
Pearu Peterson wrote:
Are you sure that you ran the tests against scipy.fftpack with fftw3 support? There were few bugs that caused some unittests to fail. The bugs are now fixed but it would be nice if new patches would not break the scipy tests in future (though it's a clever way to get attention:).
Sorry about that. I should have paid attention to testing everything - I didn't test fftn enough or run the test from scipy. I will be more careful in the future. -Matt Fishburn
Matt Fishburn wrote:
Pearu Peterson wrote:
Are you sure that you ran the tests against scipy.fftpack with fftw3 support? There were few bugs that caused some unittests to fail. The bugs are now fixed but it would be nice if new patches would not break the scipy tests in future (though it's a clever way to get attention:).
Sorry about that. I should have paid attention to testing everything - I didn't test fftn enough or run the test from scipy. I will be more careful in the future.
My bad too :( Juggling too many balls at the same time, sorry. I tried to set up fft3 for the test, but it seems I did something wrong somewhere, or ended up running the tests against the old version of scipy (I was trying not to change our system-wide install with the testing version). Whatever actually happened, sorry for the screwup, and many thanks to Pearu for the quick bailout. Cheers, f
participants (4)
-
Fernando Perez -
Matt Fishburn -
Pearu Peterson -
Ravikiran Rajagopal