![](https://secure.gravatar.com/avatar/5f88830d19f9c83e2ddfd913496c5025.jpg?s=120&d=mm&r=g)
On Thu, Apr 30, 2015 at 2:46 PM, Neal Becker <ndbecker2@gmail.com> wrote:
Gregory Allen wrote:
I was surprised to find that there was no signal.firls function in scipy for designing FIR filters using least-squares error minimization.
I wrote this based on a post in this list [http://mail.scipy.org/pipermail/scipy-user/2009-November/023101.html], added band weights, and fleshed it out in the style of signal.remez. It’s not as full-featured as the matlab version, but it solved a need for me. :)
It could be pasted at the bottom of signal/fir_filter_design.py. I include it here in case it is of any use to someone else, or to be included in scipy.
Thanks, -Greg
Thanks! A great addition.
Indeed thanks, looks quite good already. It's not added just yet though... Does one of you want to add some unit tests and send a pull request on Github? Cheers, Ralf