Good :) It runs for me.

BTW. it might be better to keep the solver in the example directory
(examples/phase_change/phase_change_solver/pcsolver.py) - you can use

from sfepy.solvers import register_solver
register_solver(PhaseChangeSolver)

to make it available to sfepy.

Could you try rebasing/updating your branch for 2013.3? Or maybe do this later,
as the pencils down date is approaching? You will need to publish the code [1]
so it better is well documented.

What are your current plans?

Thanks & cheers,
r.

[1]
http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2013/codeguidelines

On 09/19/2013 05:45 PM, Ankit Mahato wrote:
> hi R,
>
> Updated :
> https://github.com/animator/sfepy/tree/phase_change
>
> On Tuesday, 17 September 2013 17:17:11 UTC+5:30, Robert Cimrman wrote:
>>
>> On 09/17/2013 01:39 PM, Ankit Mahato wrote:
>>> R,
>>>
>>> Kindly check. Now I have pushed the tidy code along with correct
>> name/email
>>> in commits.
>>
>> Yes, the author/commiter info now seems fine.
>>
>> r.
>>
>>
>>> Regards.
>>>
>>> On Tuesday, 17 September 2013 16:28:08 UTC+5:30, Ankit Mahato wrote:
>>>>
>>>>
>>>>
>>>> On Tuesday, 17 September 2013 13:45:00 UTC+5:30, Robert Cimrman wrote:
>>>>>
>>>>> On 09/16/2013 10:29 PM, Ankit Mahato wrote:
>>>>>> Hi R,
>>>>>>
>>>>>> Here are the new problem description and solver codes
>>>>>>
>>>>>
>> https://github.com/animator/sfepy/tree/phase_change/examples/phase_change/phase_change_solver
>>>>>>
>>>>>> - It uses sfepy package for properties,mesh,vtkoutputs, etc.
>>>>>>      How should I integrate into the Solver framework?
>>>>>>
>>>>>> Regards,
>>>>>> Ankit
>>>>>
>>>>> There are several possibilities. First, the solvers have a standard
>> way
>>>>> of
>>>>> passing in/processing options, see .process_conf() of any solver, for
>>>>> example
>>>>> in sfepy.solvers.ls. Then the solution is implemented as .__call__().
>>>>>
>>>>> I would try:
>>>>>
>>>>> - use TimeStepper or VariableTimeStepper from sfepy.solvers.ts for
>> time
>>>>> stepping
>>>>> - make PhaseChangeSolver a Solver subclass and use
>>>>> PhaseChangeSolver.process_conf() for its options
>>>>> - then we will see :)
>>>>>
>>>>> r.
>>>>>
>>>>> PS: I see lots of trailing whitespace, bad indentation and other PEP8
>>>>> problems
>>>>> in your files - what editor do you use? Some setup might be needed. Or
>>>>> try
>>>>> using [1] with tweaks [2] or [3] (some configuration might be
>> required) -
>>>>> manual inspection then needed.
>>>>>
>>>>> PPS: Setup correctly you git user name and e-mail on all computers you
>>>>> use. The
>>>>> commits so far can be fixed by the attached script taking two
>> arguments -
>>>>> the
>>>>> start commit and end commit (!!!dangerous!!! - use it on a copy of the
>>>>> repo, as
>>>>> it uses the nuclear weapon of git - the filter-branch command).
>>>>>
>>>>
>>>> R, I used the script.
>>>> As stated here[http://git-scm.com/docs/git-filter-branch] -
>>>> Always verify that the rewritten version is correct: The original refs,
>> if
>>>> different from the rewritten ones, will be stored in the namespace *
>>>> refs/original/*
>>>>
>>>> I can see a file .git/refs/original/refs/heads/phase_change in that
>>>> location. but no change is reflected if I use gitk --all to view the
>>>> project. "ankit" is still present as the commiter there.
>>>>
>>>>
>>>>>
>>>>>
>>>>> [1] http://pypi.python.org/pypi/PythonTidy/
>>>>>
>>>>> [2]
>>>>> COL_LIMIT = 79
>>>>> DICT_COLON = ' : '
>>>>> ADD_BLANK_LINES_AROUND_COMMENTS = False
>>>>> MAX_SEPS_FUNC_DEF = 50  # 2007 May 24
>>>>> PARENTHESIZE_TUPLE_DISPLAY = False  # 2010 Mar 10
>>>>>
>>>>> [3] https://pypi.python.org/pypi/autopep8
>>>>>
>>>>>
>>>
>>
>>
>