On 04/20/10 15:13, Dominique wrote:
On Apr 16, 5:58 pm, Robert Cimrman<cimr...@ntc.zcu.cz> wrote:
On 04/16/10 18:49, Dominique wrote:
On Apr 16, 4:07 pm, Robert Cimrman<cimr...@ntc.zcu.cz> wrote:
Hi Dominique!
The term dw_volume_lvf expects its first argument to be a material. What you really want for int( v . q ) is dw_mass_vector (with density 1.0) or dw_volume_wdot (also with material set to 1.0).
The best term for this would be dw_volume_dot, but it's not available. There is only dw_volume_wdot, which does, in fact, the same thing as dw_mass_vector for vector arguments. So IMHO dw_mass_vector could be removed.
Also it should be an easy exercise to create dw_volume_dot by following dw_volume_wdot - just strip the material stuff. Would you like to try it? :)
r.
Hi Robert,
I could make it work with dw_mass_vector. In the source code of dw_volume_wdot, there is:
if self.vdim> 1: raise NotImplementedErrorAh ok, I missed that one.
so SfePy won't process my equations with that term in them. What's best at this point? Move the code from dw_mass_vector to dw_volume_wdot? Yes, I'll have a go at dw_volume_dot ;).
Great! Yes, you can try merging dw_volume_wdot with dw_mass_vector. I have to go now, good luck!
I think I was able to create dw_volume_dot from dw_volume_wdot but I'm still trying to understand how dw_mass_vector works. Its mechanism seems to be quite different. What is the best way to propose contributed code? Should I just fork the git repo and send pull requests?
Cool!
Yes, there is a sort of disorder in the ways terms are defined, due to historical reasons. dw_mass_vector is much older then dw_volume_wdot, where I tried to avoid C completely. I guess you can choose whatever way works. Let me see what you have.
For contributed code, you can either setup a github repo as you say, or simply send a patch using 'git format-patch' (or from GUI, if you have qgit: qgit4 -> save patch) to this list. I can then apply such patches with 'git am'. It preserves the author and date. For me the latter way is easier, as I do not have to clone anything :)
cheers, r.
-- You received this message because you are subscribed to the Google Groups "sfepy-devel" group. To post to this group, send email to sfepy...@googlegroups.com. To unsubscribe from this group, send email to sfepy-devel...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sfepy-devel?hl=en.