Hi Robert,

  I will send a patch. Let me read Git manual first :(( .


Ouyang
 

On Friday, July 25, 2014 3:00:04 PM UTC+8, Robert Cimrman wrote:
On 07/24/2014 12:23 PM, Ouyang wrote:
> Hi Robert,
>
> I think I found the small bug in base.py in
>
>      if (package_name is None) and (top_dir == path[:len(top_dir)]):
>          #package_name = path[len(top_dir) + 1:].replace('/', '.')
>          package_name = path[len(top_dir) + 1:].replace(os.sep, '.')
>          path = top_dir
>
> Using os.sep instead of '/'  is more portable here. It works now. I have
> not tested that one which crash python yet.
> No chance to test os.sep for other systems.

Hey, good catch (and a very stupid bug), thanks for debugging!

Would you like to send a patch [1] or pull request [2]?

Cheers,
r.
[1] http://sfepy.org/doc-devel/developer_guide.html#with-git
[2] https://help.github.com/articles/using-pull-requests

> Ouyang
>
> On Wednesday, July 23, 2014 10:16:31 PM UTC+8, Robert Cimrman wrote:
>
>> Thanks for the info.
>>
>> So you have both sfepy installed system-wide, and run it in-place? Does
>> removing the system-wide files change something?
>>
>> r.
>>
>> On 07/23/2014 03:59 PM, Ouyang wrote:
>>>
>>> On Wednesday, July 23, 2014 8:53:33 PM UTC+8, Ouyang wrote:
>>>
>>>       top_dir = os.path.normpath(os.path.join(base_dir, '..'))
>>>
>>> This statement assign "c:\\sfepy" to top_dir instead of
>>> "c:\\Python27\\Lib\\site-packages\\sfepy".
>>>
>>> After I hack the base.py in c:\\sfepy\\sfepy\\base\\base.py (NOT
>>> c:\\Python27\\Lib\\site-packages\\sfepy\\base\\base.py)
>>>
>>>       top_dir = "c:\\Python27\\Lib\\site-packages\\sfepy"
>>>
>>> run_tests.py  passes except  stokes_slip_bc.py which crash python.
>>>
>>>
>>>     Sfepy should call base.py at
>>> c:\\Python27\\Lib\\site-packages\\sfepy\\base\\ at very beginning.
>>>
>>>
>>> Ouyang
>>>
>>> Hi,
>>>>
>>>>      For run_tests.py for the latest sfepy in window 8, here is what I
>> do:
>>>>
>>>> 1. Installations:
>>>>    1.1 Upgrade python(x,y) from 2.7.6.0 to 2.7.6.1 (packages installed
>> are
>>>>    listed in the attached file using "yolk -l".)
>>>>    1.2 Reinstall msysgit:
>>>>       Since installation of 1.9.4 "NETINSTALL" verion of msysGit failed
>>>> (msysGit-netinstall-1.9.4-preview20140611.exe),  I installed 1.9.0
>>>> "FULLINSTALL" version of msysGit
>>>> (msysGit-fullinstall-1.9.0-preview20140217.exe at
>>>> https://github.com/msysgit/msysgit/releases).
>>>>
>>>> 2. run_tests.py:
>>>>
>>>>     2.1 Old version of sfepy:
>>>>       2.1.1 Start msysGit shell with msys.bat
>>>>       2.1.2 cd to sfepy root directory
>>>>       2.1.3 python setup.py build_ext --inplace --compiler=mingw32
>>>>          (I ignored the error info: "msvcr90.dll not found").
>>>>       2.1.4 ./run_tests.py
>>>>       2.1.5 This time, all tests are ok except stokes_slip_bc.py which
>>>> causes python
>>>> crash. It was ok before with python(x,y)-2.7.6.0 and previous msysgit
>>>> installation.
>>>>
>>>>     2.2 Latest verstion of sfepy:
>>>>       2.2.1 python setup.py clean
>>>>       2.2.2 python setup.py build_ext --inplace --compiler=mingw32
>>>>       2.2.3 ./run_tests.py
>>>>       2.2.5 No luck again: 79 test file(s) executed in 10.12 s, 63
>>>> failure(s) of 116 test(s)
>>>>
>>>> ouyang
>>>>
>>>
>>
>>
>