Yes, I would apply the patch and amend the commit, and force-pushed the result. Then there is no need to repeat the pull request - just let me know it's done and I will merge it.
Thanks! r.
----- Reply message ----- From: "Alec Kalinin" alec.k...@gmail.com To: sfepy...@googlegroups.com Subject: SfePy GitHub development workflow Date: Wed, Sep 5, 2012 17:37 FYI: I have commented the pull request...
r.
Thank you, Robert. Your changes look reasonable. So, from wokrflow point of view, should I apply you patch on top of my tutorial-FEM-notes branch in my forked repository and reapply the pull request?
Robert, could you send me the patch by e-mail? The html formatting in the github comment little broke the patch content.
Alec
On Wednesday, September 5, 2012 7:48:17 PM UTC+4, Robert Cimrman wrote:
Yes, I would apply the patch and amend the commit, and force-pushed the result. Then there is no need to repeat the pull request - just let me know it's done and I will merge it.
Thanks! r.
----- Reply message ----- From: "Alec Kalinin" <alec...@gmail.com javascript:> To: <sfep...@googlegroups.com javascript:> Subject: SfePy GitHub development workflow Date: Wed, Sep 5, 2012 17:37
FYI: I have commented the pull request...
r.
Thank you, Robert. Your changes look reasonable. So, from wokrflow point
of view, should I apply you patch on top of my tutorial-FEM-notes branch in my forked repository and reapply the pull request?-- You received this message because you are subscribed to the Google Groups "sfepy-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sfepy-devel/-/p1EQNDS0tPUJ. To post to this group, send email to sfep...@googlegroups.comjavascript: . To unsubscribe from this group, send email to sfepy-d...@googlegroups.com javascript:. For more options, visit this group at http://groups.google.com/group/sfepy-devel?hl=en.
-
Alec Kalinin -
Robert Cimrman