2017-04-04 0:59 GMT+02:00 R. David Murray rdmurray@bitdance.com:
On Tue, 04 Apr 2017 00:21:33 +0200, Victor Stinner victor.stinner@gmail.com wrote:
I don't see the point of testing the pure Python implementation, since the C accelerator (_pickle) is always used by default in Python 3. I propose to remove this benchmark. What do you think?
Are these benchmarks always going to be used only for CPython? I thought the long term goal was to support multiple implementations?
pyperformance is supposed to work on any Python implementation. The benchmarks pickle and unpickle test the "pickle" module which is generic and should be available on all Python implementation.
pickle_pure_python and unpickle_pure_python benchmarks explicitly force the usage of the pure Python implementation and so are likely to be specific to CPython.
https://github.com/python/performance/blob/master/performance/benchmarks/bm_...
Ah, the trick is that Python 2 requires to implement "cPickle" instead of "pickle". Well, since we are talking about performances, I expect that users use "cPickle" and not "pickle" on Python 2, no?
Victor