Re: [Speed] CPython Benchmark Suite usinf my perf module, GitHub, etc.

2016-07-29 19:03 GMT+02:00 Brett Cannon <brett@python.org>:
- Should it support --track_memory? it doesn't support it correctly right now, it's less precise than before (memory is tracked directly in worker processes, no more by the main process) => discuss this point in my previous email
I don't have an opinion as I have never gotten to use the old feature.
As I wrote in my other email, I implemented this feature in perf, so the benchmark suite will get it for free. The implementation is not complete, but it's working ;-)
- Should we remove vendor copies of libraries and work with virtual environments? Not all libraries are available on PyPI :-/ See the requirements.txt file and TODO.
If they are not on PyPI then we should just drop the benchmark. And I say we do use virtual environments to keep the repo size down.
Right. We can start with "a subset" of benchmarks and enlarge the test suite later, even reimport old benchmark with their dependency not on PyPI on case by case.
Right now, I only wrote requirements.txt. I didn't touch the Python which still "hardcodes" PYTHONPATH to get the local copy of dependencies. It works if you run manually benchmarks in a virtual environment.
I will write some glue to automate things and make the code "just work" bfore starting a new thing on GitHub.
Victor
participants (1)
-
Victor Stinner