On 10 January 2018 at 02:57, Victor Stinner victor.stinner@gmail.com wrote:

I would prefer to not have to install Django 1.11 *and* Django 2.0 in the same virtual environment (I'm not sure that it's technically possible). It means that the Django 1.11 benchmark would be specific to Python 2, whereas the Django 2.0 benchmark would be specific to Python 3. So with an hypothetical future performance version, it would become impossible to compare django template benchmark between Python 2 and Python 3. I'm not sure that the Python 2 benchmark would be useful.

The point of the benchmark is to test non-trivial string manipulation, not to test the latest version of Django's template engine.

Just lock the dependency at Django 1.11, and explain why.

Cheers, Nick.

-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia