Re: [Speed] merging PyPy and Python benchmark suite
On Tue, Jul 24, 2012 at 7:35 PM, Alex Gaynor <alex.gaynor@gmail.com> wrote:
On Tue, Jul 24, 2012 at 10:29 AM, Maciej Fijalkowski <fijall@gmail.com> wrote:
On Tue, Jul 24, 2012 at 7:10 PM, Brett Cannon <brett@python.org> wrote:
On Mon, Jul 23, 2012 at 7:34 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
On Mon, Jul 23, 2012 at 11:46 PM, Brett Cannon <brett@python.org> wrote:
On Mon, Jul 23, 2012 at 4:39 PM, Armin Rigo <arigo@tunes.org> wrote:
Hi Brett,
On Mon, Jul 23, 2012 at 10:15 PM, Brett Cannon <brett@python.org> wrote: > That's what I'm trying to establish; how much have they diverged > and > if > I'm > looking in the proper place.
bm_mako.py is not from Unladen Swallow; that's why it is in pypy/benchmarks/own/. In case of doubts, check it in the history of Hg. The PyPy version was added from virhilo, which seems to be the name of his author, on 2010-12-21, and was not changed at all since then.
OK. Maciej has always told me that a problem with the Unladen benchmarks was that some of them had artificial loop unrolling, etc., so I had assumed you had simply fixed those instances instead of creating entirely new benchmarks.
No we did not use those benchmarks. Those were mostly completely artificial microbenchmarks (call, call_method etc.). We decided we're not really that interested in microbenchmarks.
Hg tells me that there was no change at all in the 'unladen_swallow' subdirectory, apart from 'unladen_swallow/perf.py' and adding some __init__.py somewhere. So at least these benchmarks did not receive any pypy-specific adapatations. If there are divergences, they come from changes done to the unladen-swallow benchmark suite after PyPy copied it on 2010-01-15.
I know that directory wasn't changed, but I also noticed that some benchmarks had the same name, which is why I thought they were forked versions of the same-named Unladen benchmarks.
Not if they're in own/ directory.
OK, good to know. I realized I can't copy code wholesale from PyPy's benchmark suite as I don't know the code's history and thus if the contributor signed Python's contributor agreement. Can the people who are familiar with the code help move benchmarks over where the copyright isn't in question?
Can we find a home for benchmarks where we don't need everyone to sign the copyright agreement?
Cheers, fijal
Speed mailing list Speed@python.org http://mail.python.org/mailman/listinfo/speed
It seems totally reasonable for them to be official and be under the PSF license, and have copyright agreements signed.
Alex
-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero
PyPy benchmark suite contains stuff from twisted, sympy, mako, tons of other libraries. I doubt we can get everyone to sign the contributor agreement.
participants (1)
-
Maciej Fijalkowski