Hi all, I just wanted to let you know that I pushed an unnecessary merge to master ( https://github.com/tox-dev/tox/commit/26354873eeb7062481342fa819aa583de2b0ce...). I still need to learn how to be a contributor who opens PRs to be reviewed and a maintainer who does things directly on master at the same time. I hope my push license won't be revoked because of this, but I take this as a chance to ask for some feedback. I don't know how the more experienced devs handle this, but this is my current approach: if I see something that needs to be done that carries no risk and is uncontroversial I just do it without bothering anyone. It's all in the git history anyway. If I feel in any way insecure about the change, I go the normal route (PR or Issue or writing on the mailing list). Here are some things that fall into that first group for me: * Fixing typos, fix broken links, improve grammar in docs * Completing merged PRs like adding missing changelog entries or fixing minor oversights * changing long_description of the project, so the changelog entries of the last 5 releases are shown on pypi (suggestion from Florian to do the same as in devpi) * fixed some problems due to a merged PR that turned out to be slightly incomplete and lacked some test coverage (although there was something I did not feel sure about which I reverted then). * Preparing releases (bumping version numbers, etc.) * etc. https://github.com/tox-dev/tox/commits?author=obestwalter ... so in short a lot of stuff that is not very exciting to do, but from my current understanding part of the work of a maintainer. Those things are utterly boring if somebody else is asked to look over it and it makes no sense from my point of view to waste other peoples time with that. This also includes things where it is more work and delay to remind somebody else to do it instead of just fixing it yourself. Here are some things I opened a PR or Issue for: * Adding a Vagrantfile * Changing the way versioning is handled (introducing setuptools_scm) * Replacing all references to an old domain, where I was not quite sure if it is really obsolete * etc. https://github.com/tox-dev/tox/issues/created_by/obestwalter So that's where I stand now and that is how I am planning to carry on, unless I get new information that would lead me to reconsider that approach. Cheers, Oliver
Hi! I have the same approach. So +1 Regards, Florian Schulze On 26 Mar 2017, at 16:51, Oliver Bestwalter wrote:
Hi all,
I just wanted to let you know that I pushed an unnecessary merge to master ( https://github.com/tox-dev/tox/commit/26354873eeb7062481342fa819aa583de2b0ce...). I still need to learn how to be a contributor who opens PRs to be reviewed and a maintainer who does things directly on master at the same time. I hope my push license won't be revoked because of this, but I take this as a chance to ask for some feedback.
I don't know how the more experienced devs handle this, but this is my current approach: if I see something that needs to be done that carries no risk and is uncontroversial I just do it without bothering anyone. It's all in the git history anyway. If I feel in any way insecure about the change, I go the normal route (PR or Issue or writing on the mailing list).
Here are some things that fall into that first group for me:
* Fixing typos, fix broken links, improve grammar in docs * Completing merged PRs like adding missing changelog entries or fixing minor oversights * changing long_description of the project, so the changelog entries of the last 5 releases are shown on pypi (suggestion from Florian to do the same as in devpi) * fixed some problems due to a merged PR that turned out to be slightly incomplete and lacked some test coverage (although there was something I did not feel sure about which I reverted then). * Preparing releases (bumping version numbers, etc.) * etc. https://github.com/tox-dev/tox/commits?author=obestwalter
... so in short a lot of stuff that is not very exciting to do, but from my current understanding part of the work of a maintainer. Those things are utterly boring if somebody else is asked to look over it and it makes no sense from my point of view to waste other peoples time with that.
This also includes things where it is more work and delay to remind somebody else to do it instead of just fixing it yourself.
Here are some things I opened a PR or Issue for: * Adding a Vagrantfile * Changing the way versioning is handled (introducing setuptools_scm) * Replacing all references to an old domain, where I was not quite sure if it is really obsolete * etc. https://github.com/tox-dev/tox/issues/created_by/obestwalter
So that's where I stand now and that is how I am planning to carry on, unless I get new information that would lead me to reconsider that approach.
Cheers, Oliver
_______________________________________________ tox-dev mailing list tox-dev@python.org https://mail.python.org/mm3/mailman3/lists/tox-dev.python.org/
Hi Oliver, On Sun, Mar 26, 2017 at 17:39 +0200, Florian Schulze wrote:
Hi!
I have the same approach. So +1
me +1 too! and i think the git history of my projects is full of funny commits i caused or did especially with git ... thanks for all the good work you did in the last months! holger
Regards, Florian Schulze
On 26 Mar 2017, at 16:51, Oliver Bestwalter wrote:
Hi all,
I just wanted to let you know that I pushed an unnecessary merge to master ( https://github.com/tox-dev/tox/commit/26354873eeb7062481342fa819aa583de2b0ce...). I still need to learn how to be a contributor who opens PRs to be reviewed and a maintainer who does things directly on master at the same time. I hope my push license won't be revoked because of this, but I take this as a chance to ask for some feedback.
I don't know how the more experienced devs handle this, but this is my current approach: if I see something that needs to be done that carries no risk and is uncontroversial I just do it without bothering anyone. It's all in the git history anyway. If I feel in any way insecure about the change, I go the normal route (PR or Issue or writing on the mailing list).
Here are some things that fall into that first group for me:
* Fixing typos, fix broken links, improve grammar in docs * Completing merged PRs like adding missing changelog entries or fixing minor oversights * changing long_description of the project, so the changelog entries of the last 5 releases are shown on pypi (suggestion from Florian to do the same as in devpi) * fixed some problems due to a merged PR that turned out to be slightly incomplete and lacked some test coverage (although there was something I did not feel sure about which I reverted then). * Preparing releases (bumping version numbers, etc.) * etc. https://github.com/tox-dev/tox/commits?author=obestwalter
... so in short a lot of stuff that is not very exciting to do, but from my current understanding part of the work of a maintainer. Those things are utterly boring if somebody else is asked to look over it and it makes no sense from my point of view to waste other peoples time with that.
This also includes things where it is more work and delay to remind somebody else to do it instead of just fixing it yourself.
Here are some things I opened a PR or Issue for: * Adding a Vagrantfile * Changing the way versioning is handled (introducing setuptools_scm) * Replacing all references to an old domain, where I was not quite sure if it is really obsolete * etc. https://github.com/tox-dev/tox/issues/created_by/obestwalter
So that's where I stand now and that is how I am planning to carry on, unless I get new information that would lead me to reconsider that approach.
Cheers, Oliver
_______________________________________________ tox-dev mailing list tox-dev@python.org https://mail.python.org/mm3/mailman3/lists/tox-dev.python.org/
_______________________________________________ tox-dev mailing list tox-dev@python.org https://mail.python.org/mm3/mailman3/lists/tox-dev.python.org/
holger krekel <holger@merlinux.eu> writes:
Hi Oliver,
On Sun, Mar 26, 2017 at 17:39 +0200, Florian Schulze wrote:
Hi!
I have the same approach. So +1
me +1 too!
I'll add another +1, it's a very sane approach.
thanks for all the good work you did in the last months!
And a +1 for this too :) Regards, Floris
Hello Florian, Holger and Floris, thank you, then I will keep calm and carry on :) Cheers, Oliver On Mon, 27 Mar 2017 at 20:54 Floris Bruynooghe <floris.bruynooghe@gmail.com> wrote:
holger krekel <holger@merlinux.eu> writes:
Hi Oliver,
On Sun, Mar 26, 2017 at 17:39 +0200, Florian Schulze wrote:
Hi!
I have the same approach. So +1
me +1 too!
I'll add another +1, it's a very sane approach.
thanks for all the good work you did in the last months!
And a +1 for this too :)
Regards, Floris _______________________________________________ tox-dev mailing list tox-dev@python.org https://mail.python.org/mm3/mailman3/lists/tox-dev.python.org/
participants (4)
-
Florian Schulze -
Floris Bruynooghe -
holger krekel -
Oliver Bestwalter