Re: [Twisted-web] How to handle interrupted responses in nevow?
On 12:24 pm, peter.westlake@pobox.com wrote:
On Wed, 13 Oct 2010 17:36 +0000, exarkun@twistedmatrix.com wrote:
On 05:22 pm, peter.westlake@pobox.com wrote:
I'm about to start looking at this. Is there any formal procedure to follow, or shall I just put in a ticket and assign it to myself?
That's the formal procedure. :)
Okay, it's in as ticket 3031. I can't see a way to assign it to myself, probably because it wouldn't be sensible to give full access to random people off the Internet!
I gave you the "contributor" role which hopefully will let you do a few more things with tickets. Jean-Paul
On Thu, 14 Oct 2010 14:07 +0000, exarkun@twistedmatrix.com wrote:
On 12:24 pm, peter.westlake@pobox.com wrote:
On Wed, 13 Oct 2010 17:36 +0000, exarkun@twistedmatrix.com wrote:
On 05:22 pm, peter.westlake@pobox.com wrote:
I'm about to start looking at this. Is there any formal procedure to follow, or shall I just put in a ticket and assign it to myself?
That's the formal procedure. :)
Okay, it's in as ticket 3031. I can't see a way to assign it to myself, probably because it wouldn't be sensible to give full access to random people off the Internet!
I gave you the "contributor" role which hopefully will let you do a few more things with tickets.
Got it, thanks! Peter.
A quick question about Python style: nevow.Request is a subclass of twisted.web.server.Request, which is a subclass of http.Request, which has an attribute _disconnected. Since the name begins with an underscore, it isn't intended to be part of the public API, and I think that means I can't refer to it in nevow.Request. There are two options: 1) use notifyFinish() to set a new attribute in nevow.Request, which would end up duplicating _disconnected; 2) use it anyway, and file a request for _disconnected to become part of the published interface. Both approaches work, and I have a unit test to prove it! Which would you like me to do? Peter.
On 04:52 pm, peter.westlake@pobox.com wrote:
A quick question about Python style:
nevow.Request is a subclass of twisted.web.server.Request, which is a subclass of http.Request, which has an attribute _disconnected. Since the name begins with an underscore, it isn't intended to be part of the public API, and I think that means I can't refer to it in nevow.Request.
There are two options:
1) use notifyFinish() to set a new attribute in nevow.Request, which would end up duplicating _disconnected;
2) use it anyway, and file a request for _disconnected to become part of the published interface.
Both approaches work, and I have a unit test to prove it! Which would you like me to do?
A combination of the two sounds best to me. Use `notifyFinish` for now, and file a ticket asking for a public version of `_disconnected`. When that's done and has been released for long enough, Nevow can switch (if anyone cares enough to do it - presumably the only reason anyone would care is that using `notifyFinish` might add a miniscule additional amount of per-request overhead). Jean-Paul
On Fri, 15 Oct 2010 19:03 +0000, exarkun@twistedmatrix.com wrote:
On 04:52 pm, peter.westlake@pobox.com wrote:
A quick question about Python style:
nevow.Request is a subclass of twisted.web.server.Request, which is a subclass of http.Request, which has an attribute _disconnected. Since the name begins with an underscore, it isn't intended to be part of the public API, and I think that means I can't refer to it in nevow.Request.
There are two options:
1) use notifyFinish() to set a new attribute in nevow.Request, which would end up duplicating _disconnected;
2) use it anyway, and file a request for _disconnected to become part of the published interface.
Both approaches work, and I have a unit test to prove it! Which would you like me to do?
A combination of the two sounds best to me. Use `notifyFinish` for now, and file a ticket asking for a public version of `_disconnected`. When that's done and has been released for long enough, Nevow can switch (if anyone cares enough to do it - presumably the only reason anyone would care is that using `notifyFinish` might add a miniscule additional amount of per-request overhead).
In that case, I have a patch (attached). You also mentioned that handleSegment would need fixing: under what circumstances does that go wrong? Peter.
On Fri, 15 Oct 2010 20:50 +0100, "Peter Westlake" <peter.westlake@pobox.com> wrote:
On Fri, 15 Oct 2010 19:03 +0000, exarkun@twistedmatrix.com wrote:
On 04:52 pm, peter.westlake@pobox.com wrote:
A quick question about Python style:
...
In that case, I have a patch (attached). You also mentioned that handleSegment would need fixing: under what circumstances does that go wrong?
Should I attach the patch to the ticket, or wait for someone to have a look at it, or - what's the drill? Peter.
On 21 Oct, 09:32 pm, peter.westlake@pobox.com wrote:
On Fri, 15 Oct 2010 20:50 +0100, "Peter Westlake" <peter.westlake@pobox.com> wrote:
On Fri, 15 Oct 2010 19:03 +0000, exarkun@twistedmatrix.com wrote:
On 04:52 pm, peter.westlake@pobox.com wrote:
A quick question about Python style:
...
In that case, I have a patch (attached). You also mentioned that handleSegment would need fixing: under what circumstances does that go wrong?
Should I attach the patch to the ticket, or wait for someone to have a look at it, or - what's the drill?
Attaching patches to tickets is definitely a good thing. It's easier to keep track of things there than via email. You might also want to add the "review" keyword to the ticket to draw people's attention. Thanks, Jean-Paul
On Fri, 22 Oct 2010 13:38 +0000, exarkun@twistedmatrix.com wrote: ...
Attaching patches to tickets is definitely a good thing. It's easier to keep track of things there than via email. You might also want to add the "review" keyword to the ticket to draw people's attention.
Done, thanks: http://divmod.org/trac/ticket/3031 It's still assigned to me. Peter.
Is there any possibility that this might make it into Debian Squeeze? It's a long shot, I know, but it would save me having to install a customised version. Peter. On Fri, 22 Oct 2010 15:09 +0100, "Peter Westlake" <peter.westlake@pobox.com> wrote:
On Fri, 22 Oct 2010 13:38 +0000, exarkun@twistedmatrix.com wrote: ...
Attaching patches to tickets is definitely a good thing. It's easier to keep track of things there than via email. You might also want to add the "review" keyword to the ticket to draw people's attention.
Done, thanks: http://divmod.org/trac/ticket/3031
It's still assigned to me.
Peter.
_______________________________________________ Twisted-web mailing list Twisted-web@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web
On 05:28 pm, peter.westlake@pobox.com wrote:
Is there any possibility that this might make it into Debian Squeeze? It's a long shot, I know, but it would save me having to install a customised version.
What will have to happen for it to make it into Debian Squeeze? Jean-Paul
On Tue, 23 Nov 2010 17:43 +0000, exarkun@twistedmatrix.com wrote:
On 05:28 pm, peter.westlake@pobox.com wrote:
Is there any possibility that this might make it into Debian Squeeze? It's a long shot, I know, but it would save me having to install a customised version.
What will have to happen for it to make it into Debian Squeeze?
It would need to be reviewed and any review issues fixed, then be included in a release of Nevow. Squeeze currently includes version 0.10.0-2 of the Debian package python-nevow, so whoever maintains that would need to accept the new upstream version. I don't know how likely that is at this stage of the Debian release cycle. Peter.
Jean-Paul
On 23 Nov, 07:00 pm, peter.westlake@pobox.com wrote:
On Tue, 23 Nov 2010 17:43 +0000, exarkun@twistedmatrix.com wrote:
On 05:28 pm, peter.westlake@pobox.com wrote:
Is there any possibility that this might make it into Debian Squeeze? It's a long shot, I know, but it would save me having to install a customised version.
What will have to happen for it to make it into Debian Squeeze?
It would need to be reviewed and any review issues fixed, then be included in a release of Nevow. Squeeze currently includes version 0.10.0-2 of the Debian package python-nevow, so whoever maintains that would need to accept the new upstream version. I don't know how likely that is at this stage of the Debian release cycle.
Getting the ticket closed soon is probably doable, but I dunno if "maybe getting into Debian" is enough to motivate me to do the release work. If someone else wants to volunteer to help with that, it'd be great. Or if someone can say "Release by December 12th and it will be included in Debian" then I'll do a release by December 12th. Jean-Paul
On Nov 23, 2010, at 7:17 PM, exarkun@twistedmatrix.com wrote:
Getting the ticket closed soon is probably doable, but I dunno if "maybe getting into Debian" is enough to motivate me to do the release work. If someone else wants to volunteer to help with that, it'd be great. Or if someone can say "Release by December 12th and it will be included in Debian" then I'll do a release by December 12th.
I think that's more like "Release by Aug 6 (2010) and it will be included in Debian". Currently they are only accepting critical updates: http://lists.debian.org/debian-devel-announce/2010/11/msg00006.html
Once again, it's time to tighten up the unblock policy. We will now only accept unblock requests for:
- fixes for release critical bugs (i.e., bugs of severity critical, grave and serious) in all packages; - translation updates - documentation fixes
James
On Tue, 23 Nov 2010 19:25 -0500, "James Y Knight" <foom@fuhm.net> wrote:
On Nov 23, 2010, at 7:17 PM, exarkun@twistedmatrix.com wrote:
Getting the ticket closed soon is probably doable, but I dunno if "maybe getting into Debian" is enough to motivate me to do the release work. If someone else wants to volunteer to help with that, it'd be great. Or if someone can say "Release by December 12th and it will be included in Debian" then I'll do a release by December 12th.
I think that's more like "Release by Aug 6 (2010) and it will be included in Debian".
Currently they are only accepting critical updates:
Okay, I'm convinced :-) Perhaps they will accept it for a maintenance release. Cheers, Peter.
participants (3)
-
exarkun＠twistedmatrix.com -
James Y Knight -
Peter Westlake