Mailman 3 September 2002 - Twisted

Re: [Twisted-Python] 0.99.2rc3
by David Marko Sept. 26, 2002

Sept. 26, 2002

Whert is this release available? The link on www.twistedmatrix.com doesnt work. David Marko

3 2

[Twisted-Python] feature request for microdom
by Bruce Mitchener Sept. 26, 2002

Sept. 26, 2002

Hey DOMmies, Well, since we're using MicroDOM .. we might as well make it kick some more ass. :) In working with the Woven stuff, one thing that would help a lot in the formatted failure pages is if the __repr__ of the objects wasn't just this: <twisted.web.microdom.Element instance at 0x83a76dc> but maybe included other information about the element. The best would be to include the name of the file, the line number, the tag name and any attributes. :) But that might be … [View More]

3 2

[Twisted-Python] little bits of woven joy
by Bruce Mitchener Sept. 25, 2002

Sept. 25, 2002

Currently, if you have multiple deferreds in flight and one of them fails, future failures aren't handled nicely at all. This patch works on improving that, but isn't perfect yet. It also handles a few other things ... callbacks that were having an exception raised didn't display that in the web interface ... and if we do that, we should just return the Failure back to Deferred._runCallbacks as well to swap over to the errback chain. If someone has a good (better) idea on handling the … [View More]multiple-deferreds in flight that error out, I'd love to hear it. This is actually causing other problems as well that this problem doesn't fix .. where sometimes, parts of the page will be rendered and parts will be formatFailure output ... and sometimes the web connection never closes down and so the browser just spins on it. :) There are a couple of other problems as well, but I don't (yet) have a good enough handle on them to discuss them, much less play with fixes. The only other thing in here is a bit more data showing where it tried to look for the view method when it raises the error. - Bruce cvs server: Diffing . Index: template.py =================================================================== RCS file: /cvs/Twisted/twisted/web/woven/template.py,v retrieving revision 1.3 diff -u -r1.3 template.py --- template.py 25 Sep 2002 18:14:27 -0000 1.3 +++ template.py 25 Sep 2002 18:15:20 -0000 @@ -118,7 +118,8 @@ def renderFailure(ignored, request): f = failure.Failure() request.write(widgets.formatFailure(f)) - request.finish() + ###request.finish() + return f class DOMTemplate(Resource, View): @@ -240,6 +241,7 @@ return self.sendPage(request) except: renderFailure(None, request) + request.finish() def dispatchResult(self, request, node, result): """ @@ -276,11 +278,19 @@ Deal with a callback from a deferred, dispatching the result and recursing children. """ - self.outstandingCallbacks -= 1 - node = self.dispatchResult(request, node, result) - self.recurseChildren(request, node) - if not self.outstandingCallbacks: - return self.sendPage(request) + try: + self.outstandingCallbacks -= 1 + node = self.dispatchResult(request, node, result) + self.recurseChildren(request, node) + if not self.outstandingCallbacks: + return self.sendPage(request) + except: + f = renderFailure(None, request) + if self.outstandingCallbacks == 0: + request.finish() + else: + log.msg("Not finishing yet ... still %s remaining" % self.outstandingCallbacks) + return f def processWidget(self, request, widget, node): """ @@ -339,6 +349,7 @@ # Look up either a widget factory, or a dom-mutating method defaultViewMethod = None + sources = [self, domwidgets] view = DefaultWidget(self.model) viewMethod = self.templateMethods.getMethodForNode(node) if viewMethod: @@ -356,6 +367,7 @@ else: # Check to see if the viewMethod returns a widget. (Use IWidget instead?) maybeWidget = viewMethod(request, node) + sources = (maybeWidget) if isinstance(maybeWidget, domwidgets.Widget): view = maybeWidget viewMethod = view.generate @@ -369,7 +381,7 @@ del view del result nodeText = node.toxml() - raise NotImplementedError, "You specified view name %s on a node, but no factory_%s method was found." % (viewName, viewName) + raise NotImplementedError, "You specified view name %s on a node, but no factory_%s method was found. Tried looking on %s" % (viewName, viewName, sources) return view, viewMethod, result def handleNode(self, request, node): Index: widgets.py =================================================================== RCS file: /cvs/Twisted/twisted/web/woven/widgets.py,v retrieving revision 1.6 diff -u -r1.6 widgets.py --- widgets.py 25 Sep 2002 18:14:27 -0000 1.6 +++ widgets.py 25 Sep 2002 18:15:20 -0000 @@ -168,13 +168,16 @@ return self.generateDOM(request, node) def callback(self, result, request, node): - self.setData(result) - data = self.getData() - if isinstance(data, defer.Deferred): - data.addCallbacks(self.callback, renderFailure, callbackArgs=(request, node), errbackArgs=(request,)) - return data - self.setUp(request, node, data) - return self.generateDOM(request, node) + try: + self.setData(result) + data = self.getData() + if isinstance(data, defer.Deferred): + data.addCallbacks(self.callback, renderFailure, callbackArgs=(request, node), errbackArgs=(request,)) + return data + self.setUp(request, node, data) + return self.generateDOM(request, node) + except: + return renderFailure(None, request) def setUp(self, request, node, data): """Override this setUp method to do any work your widget [View Less]

1 1

[Twisted-Python] Heads Up: RC4
by Moshe Zadka Sept. 25, 2002

Sept. 25, 2002

I will package RC4 on the inside of 12 hours, unless you convince me there a problem and that the patch won't we available by the deadline. If you feel so, *now* is the time to mail me. Thanks Your Friendly Neighbourhood ARM

1 0

[Twisted-Python] Anchor
by Paul Boehm Sept. 25, 2002

Sept. 25, 2002

web/domwidgets.py:246: self['href'] = href or self.getData() + '/' the "+ '/'" part makes Anchor unuseable for my application because i don't want '/' appended to every link. am i misusing Anchor or can you fix this in cvs ? paul

2 1

[Twisted-Python] [PATCH] manhole example, docs update
by Brian Warner Sept. 25, 2002

Sept. 25, 2002

Based upon a suggestion by Acapnotic, I wrote up a small example of how to get started with the 'manhole' service (both a server and a transcript of accessing the Application and changing the type of server). It's attached here, in the form of a patch to docs/howto/manhole.html, and a sample server to put in docs/examples/manhole.py . Hope you find it useful. cheers, -Brian #! /usr/bin/python # demonstrate use of manhole to modify a running server from twisted.internet.app import … [View More]Application from twisted.internet.protocol import Factory from twisted.protocols.wire import QOTD from twisted.tap.manhole import Options, updateApplication app = Application("manhole-demo") # add QOTD server f = Factory() f.protocol = QOTD app.listenTCP(8123, f) # add manhole with username and password o = Options() o.parseOptions(["--user", "username", "--password", "sekrit"]) updateApplication(app, o) app.run() Index: doc/howto/manhole.html =================================================================== RCS file: /cvs/Twisted/doc/howto/manhole.html,v retrieving revision 1.6 diff -u -r1.6 manhole.html --- doc/howto/manhole.html 20 Jun 2002 09:37:48 -0000 1.6 +++ doc/howto/manhole.html 25 Sep 2002 11:55:09 -0000 @@ -39,6 +39,24 @@ can type arbitrary python code into the input area and get the results in the output area.</p> + <p>At this point, you can get access to the main <code class="API" + base="twisted.internet.app">Application</code> object. You can use that + to obtain the <code class="API" base="twisted.spread.pb">Service</code> + objects inside it, or references to the <code class="API" + base="twisted.internet.protocol">Factory</code> objects that are + listening on TCP or UDP ports, by doing:</p> + +<pre class="python-interpreter"> +from twisted.internet import app +a = app.theApplication +service = a.getServiceNamed("manhole") +(port, factory, backlog, interface) = a.tcpPorts[0] +</pre> + + <p>After that, you can do anything you want with those objects. A more + detailed example is at the bottom of this document.</p> + + <h2>Special Commands</h2> <p>There are a few special commands so far that make debugging @@ -130,6 +148,71 @@ brought to you by the <code class="API">twisted.python.explorer</code> module, which was written largely by Kevin Turner.</p> + + <h2>Example</h2> + + <p>Here's an example of using the manhole service to examine and modify + a running server. The sample code starts a Quote Of The Day (<code + class="API" base="twisted.protocols.wire">QOTD</code>) server on port + 8123, as well as a manhole service on the usual port 8787.</p> + + <a href="../examples/manhole.py" class="py-listing">manhole.py</a> + + <p>Start this running, and test it out with <code class="shell">nc + localhost 8123</code> (or <code class="shell">telnet localhost + 8123</code> if you don't have netcat installed).</p> + +<pre class="shell"> +% nc localhost 8123 +An apple a day keeps the doctor away. +</pre> + + <p>Then start the <tt>manhole</tt> client and point it at the + application: username is <tt>username</tt>, password is <tt>sekrit</tt>. + The following is a transcript of the manhole session, and looks just + like the normal python interpreter, with lines you type prefixed with + <tt>>>></tt>.</p> + +<pre class="python-interpreter"> +Hello username, welcome to twisted.manhole in manhole-demo on some computer somewhere. +Twisted 0.99.2rc2. + +>>> from twisted.internet import app +>>> a = app.theApplication +>>> a +<'manhole-demo' app> +>>> a.getServiceNamed("twisted.manhole") +<twisted.manhole.service.Service instance at 0x82d63dc> +>>> a.tcpPorts +[(8123, <twisted.internet.protocol.Factory instance at 0x82da454>, 5, ''), (8787, <twisted.spread.pb.BrokerFactory instance at 0x82dac7c>, 5, '')] +>>> f = a.tcpPorts[0][1] +>>> f +<twisted.internet.protocol.Factory instance at 0x82da454> +>>> dir(f) +['__doc__', '__implements__', '__module__', 'buildProtocol', 'doStart', 'doStop', 'noisy', 'numPorts', 'protocol', 'startFactory', 'stopFactory'] +>>> from twisted.protocols.wire import Daytime +>>> a.tcpPorts[0][1].protocol = Daytime +</pre> + + <p>Congratulations, you've just changed the Factory to use the <code + class="API" base="twisted.protocols.wire">Daytime</code> protocol + instead of the <code class="API" + base="twisted.protocols.wire">QOTD</code> protocol. Connect to port 8123 + now and see the difference: you get a timestamp instead of a quote:</p> + +<pre class="shell"> +% nc localhost 8123 +Wed Sep 25 11:14:58 2002 +</pre> + + <p>From here, you can do anything you want to your application. It is a + good idea to check the source for the <code class="API" + base="twisted.internet.app">Application</code> and <code class="API" + base="twisted.cred.service">Service</code> classes to see what else you + can extract from them.</p> + + <p>Have fun!</p> + <hr /> <address> [View Less]

3 2

[Twisted-Python] Bits from the ARM
by Moshe Zadka Sept. 25, 2002

Sept. 25, 2002

Here are the commands I wrote for the release 1848 ~/Twisted/admin/release-twisted --oldver 0.99.2rc2 -v 0.99.2rc3 --release=/twisted/Releases --checkout --upver --tag --exp --dist --docs --balls --rel --deb --debi InstallDebs still had a problem. Here is the fixin': 1849 cd /twisted/Releases/ 1851 cd debian-0.99.2rc3/ 1853 cp * ~/public_html/snapshot/ 1854 cp woody/* ~/public_html/snapshot/woody/ 1856 rm -rf Twisted-0.99.2rc3/ Great, now upgrade: 1857 sudo apt-get update … [View More]

2 1

[Twisted-Python] 0.99.2rc3
by Moshe Zadka Sept. 25, 2002

Sept. 25, 2002

I'm happy to announce rc3 is released. This release has been out in 30 minutes. Good work, everybody!

1 0

[Twisted-Python] FAILED (failures=1, errors=1164)
by Andrew Bennetts Sept. 25, 2002

Sept. 25, 2002

Running: PYTHONPATH=. python admin/runtests -t poll I get a crapload of errors. Specifically: FAILED (failures=1, errors=1164) Now, considering that we don't have that many tests, something is *really* screwy. The vast bulk are: ====================================================================== ERROR: testPBFailures (twisted.test.test_pbfailure.PBFailureTest) ---------------------------------------------------------------------- (yes, with no traceback) But there are many others … [View More]

2 1

[Twisted-Python] breaking distrib.ResourceSubscription
by Kevin Turner Sept. 25, 2002

Sept. 25, 2002

On Tue, 2002-09-24 at 06:57, Glyph Lefkowitz wrote: [...] > ResourcePublisher instance has no attribute 'remote_wasModifiedSince' I'm surprised that this is in the logs much, since it should only happen for distributed servers that set a Last-Modified header. Are personal servers serving that many static files? I would have thought that would be handled by ~/public_html. [...] > I thought that I'd mentioned this over IRC before, but let me stress it: I > think that twisted.web.… [View More]server is implementing *WAAAAY* too much of HTTP right > now. Interesting position. I know you're not a fan of complete support for a protocol when you believe the protocol itself is broken, and I'll admit that nobody actually uses ETags, but I would hardly say that Last-Modified and HEAD are obscure or unnecessary. > First of all, this is killing performance -- you have a minimum of 4 or 5 > PB server/client interactions now for each conditional request instead of 2. > Those method calls are not cheap. Recognized. Although I thought I only increased the count by one, not two or three? Also take into consideration that these calls only happen for the *conditional* requests. Resources that don't supply ETag or Last-Modified cache validation headers will probably never be bothered with them. And if the condition fails, callRemote("request") never happens, nor does all the work that goes with it. So overall, estimating its impact on performance isn't as simple as grep --count callRemote. > Second, this is exploding the complexity of > the webserver: its goal should be to get to the endpoint resource *as simply as > possible* and then invoke endpoint behavior on that resource. If clever > header-parsing things need to happen, then we need to make a lower-level > 'request' method and make *it* clever, not do request processing before the > request is dispatched. This I agree with. I knew something was wrong when I had three remote methods in ResourcePublisher all independently doing getResourceFor. It would be more symmetric if Request.process was invoked on the distri -- ggrngh. What is Request.process anyway. Is it just supposed to do site.getResourceFor and pass itself off? Yes. All the rest of the junk in there is stuff I added (though the HEAD/supportedMethods stuff was quite some time ago) with the possible exception of the util.Unauthorized block. And it's probably all logic that belongs in web..Resource rather than Request. (which is just re-iterating what you've been telling me.) So how do we fix it? You're suggesting that Request.process call Resource.request, which contains most of the stuff currently in Request.process, and Resource.request calls Resource.render if it's not a conditional request? > Third, and not least, this has broken backwards compatibility (albeit in a > mostly-harmless way) at a time when we should be focusing the most on backwards > compatibility. Sounds like we need an inter-version test harness. Runs peer1 under version X and peer2 on Y, or starts server on version X, pickles it, and re-starts under Y, etc. > I'm sending this to you directly instead of the list because I've had enough > political headaches recently and I didn't want you to think that I'm publicly > lambasting you :). I appreciate the effort that went into this feature > implementation, even if it was misguided. God help us if we can't critique the codebase in the developer's forum. I appreciate the feedback; I *told* you that I didn't think my changes had been tested "a lot". > If you think some of this > information is useful or that my views on twisted.web's architecture are not > very clear (or require public discussion), feel free to edit and re-post. Cheers, - Acap -- The moon is waning gibbous, 91.9% illuminated, 17.5 days old. [View Less]

3 3