Mailman 3 January 2015 - Twisted

[Twisted-Python] Review tag for closed tickets
by Adi Roiban 27 Jan '15

27 Jan '15

Jean Paul commented that for merged tickets I should remove the review tag. I am lost between wiki pages and sphinx documentation. Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged? ---- Since the ticket is automatically closed, maybe the bot can also remove the review ticket. Thanks! -- Adi Roiban

3 5

[Twisted-Python] Spurious failure on winxp32-py2.7
by Adi Roiban 27 Jan '15

27 Jan '15

While running tests I see that the following tests fails randomly... it it was failing from some time twisted.words.test.test_xpath.XPathTests.test_position =============================================================================== [FAIL] Traceback (most recent call last): File "C:\buildslave\twisted\winxp32-py2.7\Twisted\twisted\trial\_dist\test\test_disttrial.py", line 371, in test_runUntilFailure self.assertEqual(5, len(called)) File "C:\buildslave\twisted\winxp32-py2.7\Twisted\twisted\trial\_synctest.py", line 447, in assertEqual % (msg, pformat(first), pformat(second))) twisted.trial.unittest.FailTest: not equal: a = 5 b = 2 ---------- On my local computer (Ubuntu 14.04) the test is always skipped. Does anyone has any idea why the test is not skipped ? I would like to have stable results from this tests as with the current state I always have to double check if a failure on XP is a new one or is just this bad tests. Thanks! -- Adi Roiban

4 4

[Twisted-Python] hard dependency on setuptools
by Glyph 26 Jan '15

26 Jan '15

Hi all, I don't know how you'd install Twisted without setuptools these days anyway, but just as a heads up, as per discussion on <https://twistedmatrix.com/trac/ticket/3696#comment:79 <https://twistedmatrix.com/trac/ticket/3696#comment:79>> we are going to remove any pretense of supporting Twisted without setuptools installed. I am probably going to install it on the last buildbot environment that doesn't have it tomorrow. If you have a strong case for continuing to support optionally depending on setuptools... well, I am probably still going to do that and we can file some more tickets to support it properly instead of by accident later :). -glyph

2 1

[Twisted-Python] twistedchecker - Names of constant which are used as configuration options
by Adi Roiban 26 Jan '15

26 Jan '15

Hi, Why reviewing a patch I got into this error from twistedchecker. This is old code, just that someone it was touched by recent changes, C0103:574,12:NetstringReceiverTests.test_buffer: Invalid name "MAX_LENGTH" for type attribute (should match ((([a-z_])|([a-z]+_[a-z]))[a-zA-Z0-9]+)$) The code is like this, where TestNetstring is a line receiver protocol... so MAX_LENGTH act as a configuration option. a = TestNetstring() a.MAX_LENGTH = 699 What to do in this case and how I can have this code accepted by twistedchecker? Thanks! -- Adi Roiban

3 6

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 25 Jan '15

25 Jan '15

1 0

[Twisted-Python] Twisted Lore project development
by Adi Roiban 24 Jan '15

24 Jan '15

Hi, Is Twisted Lore project still under development. Should we accept new patches on Lore? Twisted has migrated to Sphinx ... does Twisted as a project encourage people to use Lore? I saw that it is still documented in latest version and there is no mention of being deprecated https://twistedmatrix.com/documents/current/lore/index.html Thanks! -- Adi Roiban

2 1

[Twisted-Python] the repository metadata of inevitability
by Glyph 24 Jan '15

24 Jan '15

Hi all, Right now we have an Git mirror which has bogus committer IDs for everybody. Eventually, this will become the actual real repository. Before that happens, for aesthetic reasons, I would like to fix the metadata in the mirror so that it accurately records the email address of the committer, ideally with an email address that's actually associated with their github account so the right little picture shows up :). I'll probably do this by using every committer's twistedmatrix.com <http://twistedmatrix.com/> email address, and they can either choose to associate that on Github (and Gravatar and Bitbucket or wherever) or not. Does anyone know how I would re-generate the mirror to fix this? I'd like to get it done soon before we slide further down the inexorable descent towards Git being the real upstream repository; having such a flag day after the migration seems untenable. Also: can anyone (probably only Tom Prince, unfortunately) with knowledge of how the buildbot works tell me if any of that configuration is going to need to be adjusted? Thanks! -glyph

2 4

[Twisted-Python] Permissions to trigger buildbot tests
by Adi Roiban 22 Jan '15

22 Jan '15

Hi, To help with the review process I would like to ask permissions for triggering buildbot builds. Is there a wiki page describing what are the steps required for a regular contributor to get permissions to run buildbot tests and get write access to the repo? -------- In the same time, maybe we can write a few words about the steps required for a new contributor to become a full reviewer. Ex. 1. Contribute a few patches (ex 10) and learn the basic review process. Observe how reviewers respond to your patch. 2. Start doing review as junior reviewer, without merging. Once you are ok with the patch, invite another core developer to take a final view and merge the patch 3. Once you have reviewed a few patches without errors (ex 10) you can ask for full review permission or a core developer will let you know that you can merge the patch without asking someone else. This can be part of the current review process page: https://twistedmatrix.com/trac/wiki/ReviewProcess What do you think? Is not much, but should provide some guidance and hope! Thanks! -- Adi Roiban

5 23

[Twisted-Python] Twisted receiving buffers swamped?
by Tobias Oberstein 20 Jan '15

20 Jan '15

Hi, I am doing network performance tests using netperf on a trivial Twisted TCP echo server (code at the end). One of the tests that netperf offers is throughput, and I am running into an issue with this. When running the test (loopback) for 10 seconds on the test box I get a throughput of 11.5 Gb/s (which is not bad): [oberstet@brummer1 ~]$ netperf -N -H 127.0.0.1 -t TCP_STREAM -l 10 -- -P 9000 TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 9000 AF_INET to 127.0.0.1 () port 9000 AF_INET : no control : histogram : interval : dirty data : demo Recv Send Send Socket Socket Message Elapsed Size Size Size Time Throughput bytes bytes bytes secs. 10^6bits/sec 0 32768 32768 10.02 11517.89 [Sidenote: when running against the netperf server, the box does 46Gb/s on that test. More results here: https://github.com/crossbario/crossbar/wiki/Stream-Testee#netperf] However, when I run the test for 60 s (changing to "-l 60" in above will do), the test server is killed by the OS due to out-of-memory. This screenshot http://picpaste.com/pics/Clipboard03-DllXR7QE.1420107551.png shows that the server at the time immediately before of killing allocated >30GB RAM. In fact, memory also runs away with 10 sec test .. it's just that the machine has enough RAM to cope with that. So it's a "general" issue. I tested with: * CPython 2.7.9 and PyPy 2.4 * select, poll and kqueue reactors all on FreeBSD 10.1. Same behavior for all combinations. === Now, my suspicion is that Twisted is reading off the TCP stack from the kernel and buffering in userspace faster than the echo server is pushing out stuff to the TCP stack into the kernel. Hence, no TCP backpressure results, netperf happily sends more and more, and the memory of the Twisted process runs away. I am aware of http://twistedmatrix.com/documents/14.0.0/core/howto/producers.html, but that seems to cover the sending side only. What's the cause? What can I do? How do I prevent Twisted to read off sockets from kernel as the userspace buffer grows? E.g. can I set a limit on the userspace buffer, so Twisted won't read out the sockets until the app has consumed more of the already buffered stuff? Any hints appreciated, Cheers, /Tobias TCP Echo Server used ====> from twisted.internet import kqreactor kqreactor.install() #from twisted.internet import selectreactor #selectreactor.install() #from twisted.internet import pollreactor #pollreactor.install() from twisted.internet import protocol, reactor, endpoints class Echo(protocol.Protocol): def dataReceived(self, data): self.transport.write(data) class EchoFactory(protocol.Factory): def buildProtocol(self, addr): return Echo() endpoints.serverFromString(reactor, "tcp:9000").listen(EchoFactory()) print "running on ", reactor.__class__ reactor.run()

5 32

[Twisted-Python] GSoC '15
by Sartaj Singh 20 Jan '15

20 Jan '15

Hello, I am a student hoping to participate in GSoC'15. I have used twisted in past in various projects. I wanted to know if twisted will be participating in GSoC this year. -- Regards *Sartaj Singh* *Mathematics and Computing*, Indian Institute of Technology, Varanasi - 221 005 INDIA E-mail: singhsartaj94(a)gmail.com, *sartaj.singh.apm13(a)itbhu.ac.in <sartaj.singh.apm13(a)itbhu.ac.in>*

1 0