hi there, folks:
I'd really like to release 0.7.0 but I would like it to be at least a
little bit tested before I do so. Could those of you with CVS trees check
everything out and see if it performs as advertised? Deeper bugs than
that will have to wait for the next release, but I'd at least like to know
if it works for someone other than me.
______ __ __ _____ _ _
| ____ | \_/ |_____] |_____|
|_____| |_____ | | | |
@ t w i s t e d m a t r i x . c o m
I have started working with Twisted and found it to be a very powerful
package. That said, some modules are not documented very thoroughly (big
surprise in the world of software, right?) and I also found some
questionable code, too.
If I were to contribute fixes/improvements, what is the submission
I'm studying an SSH client implementation using Conch, and was surprised to see that the ClientFactory subclass had a connect() method which calls connectTCP. This isn't really a problem - the code works - but it seems like an odd place to do the connection. Am I right to be surprised?
I just glanced at https://github.com/twisted/twisted/pull/1417 <https://github.com/twisted/twisted/pull/1417> after it was merged and noticed a few problems:
- It exposes a new top-level name rather than setting the protocol version as a parameter
- The NEWS files are malformed which is going to lead to some confusing duplication in the changelog
- AMPv2 itself does not appear to be "standardized" - the page at https://amp-protocol.net/conversations_v2.html <https://amp-protocol.net/conversations_v2.html> appears to be a preliminary suggestion for how long values might be handled rather than something broadly implemented; for one thing, I'd never heard of it before and for another the site itself doesn't link the document. This would be fine as a first draft, but I think it needs to be given some more revisions, given that (for example) there are a number of backwards-compatible ways to do this.
- The layering is wrong because it puts the protocol-parsing into a leaf class in the hierarchy, when the parsing logic was deliberately isolated to a lower level to facilitate different framing mechanisms.
- As JP pointed out, the tests have a potential bug where they can leak errors between cases.
I don't normally like to revert folks' work once it's been reviewed and accepted, particularly when there's no process violation (broken CI, lack of code coverage etc), but I'm particularly concerned about lending Twisted's imprimatur to this protocol extension as a whole new version without much more context on who is implementing it and what other options were considered, particularly when I personally (nominally the inventor of AMP) don't like the direction it has taken :).
What do other folks think? Anyone else have more of a finger on the pulse of where the "v2" conversation has been happening?
I have continued to work slowly on this project. Named pipes are
supported, the samba client can connect and list available shares.
i am currently working on a vfs layer using deferToThread to provide
asynchronous file access
I have tried to keep the code divided into logically separate chunks .
my first chunk received comments from glyph 2 months ago but has
remained in the review queue since.
is there anyone available to review this code to progress it ?