Mailman 3 March 2021 - Twisted

[Twisted-Python] Small amount of feedback for a contributor to address?
by Glyph 21 Mar '21

21 Mar '21

I just reviewed https://twistedmatrix.com/trac/ticket/10052#comment:5 and it’s almost landable, it just needs a small amount of feedback addressed to land. Given that the submitter had to wait months for this review I don’t know if they’re tracking it closely, so I figured I’d raise it here to see if anyone else had a moment to nudge a good bugfix here over the line. Thanks in advance to whoever picks it up, -g

1 0

[Twisted-Python] automat question
by Chris Withers 16 Mar '21

16 Mar '21

Hi, Apologies if there's a better list for this, please let me know where... I've grown to like Glyph's automat package a lot, but in a current project, I have observers that need to know when a machine changes state. What's the best way to let those observers know? cheers, Chris

2 7

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 14 Mar '21

14 Mar '21

1 0

[Twisted-Python] Probot app to automatically delete merged branches
by Adi Roiban 13 Mar '21

13 Mar '21

Hi, Do you see anything bad in enabling the delete-merged-branch app for twisted/twisted ? https://probot.github.io/apps/delete-merged-branch/ Right now Twisted has 1877 branches. My hope is that in this way we can keep the main repo clean and there will be less noise in autocompletion. Now, this will only handle future branches/merges ...but at least is a start. We can see later what to do with existing branches. Cheers -- Adi Roiban

2 3

[Twisted-Python] reactor for Linux io_uring
by Ian Haywood 13 Mar '21

13 Mar '21

In investigating async file I/O I came across this. In a nutshell it's the new epoll() It's marginally more efficient although this is only apparent at very high loads. What's more interesting is that io_uring accepts files as well as network/pipe handles: avoiding the need for threads. Here's a good intro: https://unixism.net/loti/index.html If people think an IoUringReactor is worthwhile I'll open a ticket and make a start. However it will need a reviewer... :-) Ian

9 20

[Twisted-Python] code contribution/participation policy
by Boris Epstein 10 Mar '21

10 Mar '21

Hi all, I have started working with Twisted and found it to be a very powerful package. That said, some modules are not documented very thoroughly (big surprise in the world of software, right?) and I also found some questionable code, too. If I were to contribute fixes/improvements, what is the submission procedure? Thanks. Boris.

4 8

[Twisted-Python] Post Release updates
by Adi Roiban 07 Mar '21

07 Mar '21

Hi, Happy to see a new version of Twisted released. Thanks to anyone for making it happen. --------- I think that https://github.com/twisted/twisted/pull/1514 should be merged to finalize the release process. ------ And we have not yet decided if the trunk should be using `.dev` or .post` :( https://twistedmatrix.com/trac/ticket/9542 I am +1 for .post1 ... as it has the semantic of a post release version. while .dev0 is a pre-release. ---------- The https://twistedmatrix.com/documents/current/ documentation was not updated. But that can be solved after the release. I will see if I can update it tonight... and I will check over IRC to see if someone else has fixed it. First, I am looking at the Read the docs release issues... it looks like things are not as automated as we though :D ------------- I have no idea why the latest tag is not visible on Read the docs https://readthedocs.org/projects/twisted/versions/ I have manually activated it based on the f1daeeee tag. I went to https://readthedocs.org/projects/twisted/versions/?version_filter=twisted-2… and then clicked "Activate" Then I went to https://readthedocs.org/dashboard/twisted/advanced/ and select it as "Default" version and then click "Save" Then I went to https://readthedocs.org/projects/twisted/builds/ to check the status of the new build. I see that we now have - https://docs.twistedmatrix.com/en/twisted-21.2.0/ But https://docs.twistedmatrix.com/en/stable/ is still an older build :( I have no idea why... looks like stable is not active and what is origin/8690 [image: image.png] Maybe Read The Docs is confused by `twisted-21.2.0` as it doesn't look like a semantic version . ---------- Stable was building for https://github.com/twisted/twisted/commit/99137f53a8a6bd1d8bffa520237323616… See RTD stable build https://readthedocs.org/projects/twisted/builds/13125823/ So I have wiped the stable version and now it gets 404. I (or someone else from the team) will have check with Read The Docs team to see why we have this issue with the stable version. ---------- And there are a lot of versions as we have many branches on Twisted. I guess that at least the branches that were merged, could be removed from the main repo. I don't see the value for keeping them alive, That is all for now. -- Adi Roiban

7 16

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 07 Mar '21

07 Mar '21

1 0

[Twisted-Python] conch bytes/str traceback when /etc/ssh/moduli is not present
by Werner Thie 06 Mar '21

06 Mar '21

Aloha should the case of a missing moduli file be handled more gracefully than with a traceback or is this a bug? I was running into this problem when installing on different OSs with OSX and FreeBSD not having an /etc/ssh/moduli file by default. Mahalo, Werner 2021-03-04T15:04:51+0100 [builtins.ConchSSHFactory#info] disabling non-fixed-group key exchange algorithms because we cannot find moduli file 2021-03-04T15:04:51+0100 [builtins.ConchSSHFactory] Unhandled Error Traceback (most recent call last): File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/python/log.py", line 85, in callWithContext return context.call({ILogContext: newCtx}, func, *args, **kw) File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/python/context.py", line 83, in callWithContext return func(*args, **kw) File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/internet/selectreactor.py", line 149, in _doReadOrWrite why = getattr(selectable, method)() --- <exception caught here> --- File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/internet/tcp.py", line 1403, in doRead protocol.makeConnection(transport) File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/internet/protocol.py", line 508, in makeConnection self.connectionMade() File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/conch/ssh/transport.py", line 512, in connectionMade self.sendKexInit() File "/Users/anon/.pyenv/versions/3.7.10/lib/python3.7/site-packages/twisted/conch/ssh/transport.py", line 535, in sendKexInit NS(b",".join(self.supportedPublicKeys)), builtins.TypeError: sequence item 0: expected a bytes-like object, str found 2021-03-04T15:04:51+0100 [twisted.conch.ssh.transport.SSHServerTransport#info] Disconnecting with error, code 3 reason: b"couldn't match all kex parts" 2021-03-04T15:04:51+0100 [twisted.conch.ssh.transport.SSHServerTransport#info] connection lost

3 6

[Twisted-Python] Klein?
by Robert DiFalco 05 Mar '21

05 Mar '21

Is this the right place to ask klein questions? I'm writing a metrics plugin for Klein and I can't figure out how to inject a metrics handler so that I can get route, path, duration, and status code. What I'm doing now sucks because Klein and twisted interact in complex ways on Failure and status codes. # Replace the klein _call with the metrics generating call _app._call = _callWithMetrics Rather than replace _call with my version of _call I was hoping there was a cleaner way to get the start and stop with the result code of a route invocation. Thoughts?

3 4