On 21/02/2021 00:31, Richard van der Hoff wrote:

On 15/02/2021 02:53, Craig Rodrigues wrote:
It's time for another Twisted release!

There are two major announcements for this release:

- Python 2.7 support has been dropped.  Twisted 21.2.0 supports Python 3.5 and higher only
- This will be the last Twisted release to support Python 3.5.

Thanks Craig for getting this release ready.

It looks like it is incompatible with Python 3.5.2: exception as below. There's no real reason you should care about this, except that it is (still!) what Ubuntu 16.04LTS ships with, and Ubuntu claim to still be supporting 16.04 until April this year, so this might catch a few people by surprise, as it did me[1]. Anyway, I suggest bumping `python_requires` in `setup.cfg` (https://github.com/twisted/twisted/blob/trunk/setup.cfg#L27), to stop the new version being installed on systems where it won't work.

It also breaks compat with treq 20.4 and earlier. This may or may not be a thing you care about:

  File "/home/rav/work/synapse/synapse/http/client.py", line 33, in <module>
    import treq
  File "/home/rav/work/synapse/env3/lib/python3.8/site-packages/treq/__init__.py", line 5, in <module>
    from treq.api import head, get, post, put, patch, delete, request
  File "/home/rav/work/synapse/env3/lib/python3.8/site-packages/treq/api.py", line 5, in <module>
    from treq.client import HTTPClient
  File "/home/rav/work/synapse/env3/lib/python3.8/site-packages/treq/client.py", line 11, in <module>
    from twisted.python.compat import _PY3, unicode
ImportError: cannot import name '_PY3' from 'twisted.python.compat' (unknown location)