On Apr 11, 2022, at 11:29 AM, Jean-Paul Calderone <calderone.jeanpaul@gmail.com> wrote:
On Wed, Apr 6, 2022 at 9:21 PM Jean-Paul Calderone <exarkun@twistedmatrix.com <mailto:exarkun@twistedmatrix.com>> wrote: Hello,
I've just written up an idea for an approach to getting many parts of Twisted and Twisted-based applications onto coroutines (ie `async def`).
Details are given on https://twistedmatrix.com/trac/ticket/10327 <https://twistedmatrix.com/trac/ticket/10327>
The change involves the potential for some incompatibilities - though as I described on the ticket, I think these are likely to be very rare in practice and worth imposing for the resulting payoff.
This thread represents the start of the process for making incompatible changes to Twisted as described at https://twistedmatrix.com/documents/current/core/development/policy/compatib... <https://twistedmatrix.com/documents/current/core/development/policy/compatib...>
Thanks to everyone who supplied feedback. Since it seemed positive, I've taken the next step in the process - https://github.com/twisted/twisted/pull/1718 <https://github.com/twisted/twisted/pull/1718> is a PR that implements the proposed change in behavior.
According to the compatibility policy, this should be accepted if three committers approve and there are no objections for one week.
I'm not in any huge rush so I don't imagine trying to merge this in exactly 7 days from this email (in fact, I'm on vacation all next week...)
Please have a look and let me know if you spot any problems.
It’s not a huge problem, but I reviewed on github and my only real feedback is “I think we should use a regular `isinstance`.” But I’ll leave it to you as the author of this change to make the call. Hopefully another committer or two can have a look soon. -g