On 17 Nov. 2016, at 18:22, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:

On Nov 16, 2016, at 11:15 PM, Mark Williams <markrwilliams@gmail.com> wrote:

On Thu, Nov 10, 2016 at 07:56:52PM +1100, Amber "Hawkie" Brown wrote:
- Python 3 support for Words' IRC support and twisted.protocols.sip among some smaller modules,

I have opened a PR to revert this:


A full explanation is here:


In summary: a valid IRC message will cause a UnicodeDecodeError within
the event loop that a user cannot handle or avoid, and all length
checks on line sizes are wrong because they occur prior to encoding to

Reverts should be commits that go straight to trunk and reopen tickets, per the current process.

However; is it really a regression to have py3 support for Words that just doesn't support other encodings yet?  It strikes me that this is just a bug, and that we should just fall back from UTF-8 to latin-1 in this scenario.  But adding that fallback is a small additional fix (perhaps one that should be slated for 16.6.0 if you want to make it).


Yeah, this is just a plain old bug. Bugs in new features (where a module being on Python 3 counts as one to me) aren't regressions; we sometimes fix them in pre if there's time/other stuff is getting fixed, but this one will just be a known bug until 16.7 in December.

- Amber