Nov. 30, 2020
6:07 p.m.
On Mon, 30 Nov 2020, at 13:38, Jean-Paul Calderone wrote:
On Mon, Nov 30, 2020 at 6:48 AM Peter Westlake <peter.westlake@pobox.com> wrote:
__ I'm studying an SSH client implementation using Conch, and was surprised to see that the ClientFactory subclass had a connect() method which calls connectTCP. This isn't really a problem - the code works - but it seems like an odd place to do the connection. Am I right to be surprised?
Putting transport setup on the factory unnecessarily couples protocol and transport logic. More flexibility is provided by keeping these concerns independent.
That was my feeling too. Thanks! Peter.