On Wednesday, February 10, 2021, Glyph <glyph@twistedmatrix.com> wrote:
On Feb 10, 2021, at 12:40 AM, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
How will this patch change for people installing Twisted on Windows?
Twisted is still used by a lot of users on Windows, and the IOCP Reactor is still used on this platform.
This line is what does the trick:
https://github.com/twisted/twisted/pull/1446/files#diff- fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R34
Basically, on Windows, you'll automatically get the `twisted-iocpsupport` module as a hard dependency. On other platforms, you won't. Unless you're using a *truly* ancient `pip` (which is less likely on Windows, where people tend to install things themselves rather than getting them from a calcified platfom) this will just work ✨ magically
Ok, thanks for the clarification. That is worth calling out in the release announcement, since that is a major change for Windows users. Is the https://github.com/twisted/twisted-iocpsupport repository subject to the same rules as the Twisted core repository such as: - must have a Trac ticket - PR can only be merged after review approval from a reviewer with write access to the https://github.com/twisted/twisted-iocpsupport repository. etc.? -- Craig