
Someone wanna look into this? There's a bunch of failures that look like this in test_conch/test_sftp on gtk2. These seem to show up consistently, at least. Perhaps the testcases are incorrectly calling crash multiple times? Is that supposed to be allowed by the reactor API? It doesn't specify, and the default implementation allows multiple calls of crash but not stop. ======================================================================== ======= [ERROR]: testOurServerCmdLineClient (twisted.conch.test.test_conch.SSHTransportTestCase) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/python/log.py", line 54, in callWithLogger return callWithContext({"system": lp}, func, *args, **kw) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/python/log.py", line 41, in callWithContext return context.call({ILogContext: newCtx}, func, *args, **kw) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/python/ context.py", line 52, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/python/ context.py", line 31, in callWithContext return func(*args,**kw) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/internet/ gtk2reactor.py", line 200, in _doReadOrWrite self._disconnectSelectable(source, why, didRead == source.doRead) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/internet/ default.py", line 141, in _disconnectSelectable selectable.readConnectionLost(f) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/internet/ tcp.py", line 314, in readConnectionLost self.connectionLost(reason) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/internet/ tcp.py", line 326, in connectionLost protocol.connectionLost(reason) File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/conch/test/ test_conch.py", line 339, in connectionLost reactor.crash() File "/home/buildbot/BuildBot/slave/reactors/Twisted/twisted/internet/ gtk2reactor.py", line 167, in crash self.__crash() exceptions.RuntimeError: called outside of a mainloop ======================================================================== ======= http://www.twistedmatrix.com/buildbot/reactors/builds/224/gtk2/2 James