Re: [Twisted-Python] mypy integrated with CI for twisted

On Jun 23, 2020, at 5:34 AM, Adi Roiban wrote:

Hi Craig,

On Tue, 23 Jun 2020 at 00:36, Craig Rodrigues mailto:rodrigc@crodrigues.org> wrote: I have merged some more fixes for mypy to Twisted trunk branch.

In trunk, you can run mypy with:

tox -e mypy

Currently this results in 171 errors, which is way down from >1000 errors a month ago.

In addition, if you look at any new PR's there is a Mypy Ubuntu job running on Azure pipeline, which runs mypy. Right now errors from this job are ignored and does not block the PR. However, if we can get the mypy errors down to zero, we can make mypy status a blocker for the PR.

Thanks for working on this.

Looking forward to have a real green mypy build.

A general question: Why Twisted used Azure Devops and not GitHub actions?

Azure Pipelines gave us substantially more parallel capacity than is available via Github Actions, which means we can make build statuses appear much sooner. Plus they support more platforms. For what it's worth, this build should just be "mypy", not "mypy ubuntu"; there should never be any differences between mypy on different platforms since it's statically analyzing the code. If there are, that sounds like it's mypy's problem, not ours, so it shouldn't be on our CI :). -glyph