On Mon, Oct 2, 2017 at 7:20 AM, Adi Roiban <adi@roiban.ro> wrote:
Hi,
1. Are Travis OSX builds functional yet? Can we switch to Travis for OSX builder?
Over https://www.traviscistatus.com/ I see no backlog for macOS.
No backlog right now but what about most of the rest of the time? Monday at 7AM ET is probably about the least busy possible time for travis.
------------
2. Right now, when we receive a PR from a non-team member, I think that the only way to trigger the required tests is to create a new branch in twisted/twisted.
Then you can go to https://buildbot.twistedmatrix.com/boxes-supported?branch=9176- inlinetracebacks-tardyp and force the tests.
This looks complicated, so what I was doing, is create a new PR.
--------
Am I doing something wrong? Is there a simple way? Am I the only one who thinks this is not productive?
Use admin/pr_as_branch
--------
What I am thinking is to have a single PR (the once created by the author).
Once a Twisted team member has reviewed/checked the PR, a message like "Go, Buildbot, go!" can be left as a comment and the Buildbot GH hook will trigger the stable tests for that branch.
In this way, buildbot runs are only triggered for external branches after a core team member has checked the code and assure that no malware is contained.
With GitHub we can do changs to any forked repos... so if small changes are required, Twisted team members can push directly to the external forks... not sure if this is a feature or a security bug :)
---------
What do you think? Do you see any problem in this? Will such a change make life easier for you?
This doesn't seem inherently bad, though you probably need per *revision* signoff, not per branch signoff.
I should be able to update the current GH Buildbot hook to handle the proposed change.
-- Adi Roiban
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python