Re: [Twisted-Python] Review tag for closed tickets

On 26 January 2015 at 20:11, Glyph Lefkowitz wrote:

On Jan 26, 2015, at 11:12 AM, Adi Roiban wrote:

Jean Paul commented that for merged tickets I should remove the review tag.

I am lost between wiki pages and sphinx documentation.

https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachan... pretty much describes the whole process.

Notice that the "remove the review keyword" step comes before the "merge the change to trunk" step.

Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged?

The reason you are not finding this in a list of steps after the branch is merged is because it should be done in advance of merging the branch, you skipped an earlier part of the process :).

True. Thanks! My bad... but then it also state "Make sure that it's green! " ... but in a previous email I just found out that is ok for twistededchecker and pyflakes to be red.

Since the ticket is automatically closed, maybe the bot can also remove the review ticket.

The review should be completed before the ticket is merged, so the bot should not be doing this automatically.

but in the commit message I do add the author, why not have the bot automatically assign the first author form the list, review merge and close the ticket? What is the purpose of these manual task and why you don't want to automate them? PS: Trac "reasing to" field is a PITA :) -- Adi Roiban