It could affect the workflow of people with write-access though.
If those are GitHub labels and only modifiable by repo owners, it sounds
like a sane thing to do.
One thing that would worry me though, is that more commits could come to
that PR after the reviewer (repo owner) sets the 'OK to merge' tag, I
guess such a tag should be associated with the last commit but I'm not
too sure that's possible out of the box with GitHub.
(I know that there are ways that bots can facilitate this, and if someone else would like to set that up, that would be great.)
Maybe a bot could figure out the last reviewed commit and remove the
label if it detects new (not reviewed) commits in that PR.
I... would actually be interested in taking a look at it, got any
pointers / are there already some bots for the twisted project running?
--
Evilham
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.comhttps://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python