Update: I went through the queue and gardened it substantially. There were a bunch of tickets where folks had forgotten to remove the review keyword upon closure, some with malformatted commit messages so they weren't closed (this is very hard to enforce mechanically, but please, use the template in the PR boilerplate), and some with merge conflicts that needed addressing before review.

I also pushed the "update branch" button on a whole lot of PRs so hopefully some CI detritus that made tests fail for spurious reasons will be cleared out, and everything will be reasonably up to date.

We are now down to 17 matches, but this does give me a commanding lead on this month's leaderboard:

I look forward to being dethroned.


On Jul 19, 2021, at 9:38 PM, Glyph <glyph@twistedmatrix.com> wrote:

Hello Twisted friends,

This is just a friendly reminder that https://twisted.reviews is full to bursting - 34 open reviews right now, some dating back as far as May of last year.  If you've got a few free minutes, can you find a ticket on that list and review the associated PR?  (I recently fixed the report so it's actually in the order you should review them...)  A short review queue is a happy review queue.

Remember also that this isn't for nothing, if you do code reviews on Twisted you get internet points and bragging rights, at https://twistedmatrix.com/highscores/.

This isn't just for project members; if you did not already know, the rule is that if you're a project member you can review anything, but if you're an external contributor, you can review submissions by project members (and it's up to them to decide if your review is adequate before acting on it).  Project members (should) have a "*" next to their name in the "submitted by" list.  (If they don't I think someone needs to go manually update a list of strings, feel free to report issues if that's wrong.)

Happy hacking,