Re: [Twisted-Python] [INCOMPATIBLE CHANGE] Removing Gadfly support from adbapi

We don't! Those tests never run, because "import sqlite" doesn't work on 2.7. Today's plan is to put up a patch to test stdlib sqlite3 and pysqlite2 :) On 5 Dec 2015 09:29, Glyph Lefkowitz wrote:

...

On Dec 4, 2015, at 4:07 AM, Amber Hawkie Brown wrote:

So, apparently, a long time ago, there was a database called Gadfly, and Twisted used to test adbapi against it. However, since then, we've moved on from Python versions that gadfly supports, so it outright doesn't work now -- not buggy, not weird -- just doesn't even import.

This doesn't change any user facing code, but does change some tests, and even though it's covered under the compatibility policy, I thought I'd put it on the ML anyway. :)

You can find the code at https://twistedmatrix.com/trac/ticket/8119. We do not require any signoffs to remove it, this email is purely informational.

- Amber

I think the all-caps policy-compliant "INCOMPATIBLE CHANGE" was maybe a little overkill, given it's not actually incompatible under the policy definition, but thanks for announcing nonetheless :).

The purpose of testing with gadfly was just to have a database that didn't require an external process set up; I don't think anyone seriously used Gadfly ever.  So the modern equivalent would be sqlite3 - do we test against that?  (I seem to recall that we do...)

-glyph

_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python