On Tuesday, 20 July 2021 05:38:23 BST Glyph wrote:
Hello Twisted friends,
This is just a friendly reminder that https://twisted.reviews https://twisted.reviews/ is full to bursting - 34 open reviews right now, some dating back as far as May of last year. If you've got a few free minutes, can you find a ticket on that list and review the associated PR? (I recently fixed the report so it's actually in the order you should review them...) A short review queue is a happy review queue.
$ curl https://twistedmatrix.com/trac/report/25 curl: (7) Failed to connect to twistedmatrix.com port 443: Connection refused
Remember also that this isn't for nothing, if you do code reviews on Twisted you get internet points and bragging rights, at https://twistedmatrix.com/highscores/ https://twistedmatrix.com/highscores/.
This isn't just for project members; if you did not already know, the rule is that if you're a project member you can review anything, but if you're an external contributor, you can review submissions by project members (and it's up to them to decide if your review is adequate before acting on it). Project members (should) have a "*" next to their name in the "submitted by" list. (If they don't I think someone needs to go manually update a list of strings, feel free to report issues if that's wrong.)