
Aug. 18, 2014
8:34 p.m.
Hi Glyph, thx for your feedback! > Is this otherwise ready for review? Not ready for review: there's even to check the interoperability with twistd ;) I was concerned about to be on the right track, eg: 1- is it fine to patch SyslogObserver.syslog or should I pass it as a parameter to SyslogObserver(...,syslog=stdsyslog.syslog)? 2- should syslog severity be implemented _syslog.py or in LogLevels On Monday 18 August 2014 12:19:11 Glyph Lefkowitz wrote: > > ..a stub of SyslogObserver to the new t.p.logger. > > > > https://github.com/ioggstream/twisted/commit/991156e1124d61ad26da0be121230 > > 79ffc45764c > ...DummyFile looks unnecessary. > you copied and pasted out of test_file.py. As I didn't know how the new logger worked, I started duplicating: * _file.py -> _syslog.py * test_file.py -> test_syslog.py And merging t.p.test.test_syslog behavior into test_syslog. > You weren't writing tests last, were you? ;-) Nope :) Iteratively modifying test_syslog.py then _syslog.py so that I could get in touch with the new logger. Thx again for all your time + Peace, R. -- Roberto Polli Community Manager Babel - a business unit of Par-Tec S.p.A. - http://www.babel.it T: +39.06.9826.9651 M: +39.340.652.2736 F: +39.06.9826.9680 P.zza S.Benedetto da Norcia, 33 - 00040 Pomezia (Roma)