I have found another issue I'm wondering a little how to handle. There are places in the bana_test file that sys.maxint is used. This no longer exists in python3, so how should it be handled. Should we make an artificial maxint to use for python3. I might want to note that it is not used for comparison, but to create an integer over a given size:

foo = [1, 2, [3, 4], [30.5, 40.2], 5,
               [b"six", b"seven", [b"eight", 9]], [10],
               # TODO: currently the C implementation's a bit buggy...
               sys.maxint * long(3), sys.maxint * long(2), sys.maxint * long(-2)]

regards,
Jørn lomax

On 02.07.2015 21:21, Glyph Lefkowitz wrote:

On Jul 2, 2015, at 11:12 AM, Glyph <glyph@twistedmatrix.com> wrote:

On Jul 2, 2015, at 6:13 AM, Itamar Turner-Trauring <itamar@itamarst.org> wrote:

On 2015-07-01 17:33, Glyph wrote:

We may actually need to change the wire protocol to allow some applications to continue to work on py3, to allow for a 'text' type that corresponds to Python unicode. This should probably be done after the initial port though.

Really? That seems like Jelly's job, not Banana's.

Yes, you're right.

Furthermore (I thought I remembered this!) Jelly already has support for unicode, so nothing will need to change :).

-glyph
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python