On Dec 29, 2016, at 11:01 AM, ex vito <ex.vitorino@gmail.com> wrote:
On 2016-12-29, at 12:23, Glyph Lefkowitz <glyph@twistedmatrix.com <mailto:glyph@twistedmatrix.com>> wrote:
On Dec 27, 2016, at 19:15, ex vito <ex.vitorino@gmail.com <mailto:ex.vitorino@gmail.com>> wrote:
Other than looking for confirmation, I have a fix which I included two isolated commits in the PR. Twisted project members: if this is confirmed, maybe a ticket should be created in Trac and an independent PR created, correct?
You should definitely create that ticket. In fact, you don't need to wait for confirmation - create the ticket now, and send the link to it, so someone else can comment on the ticket when it is confirmed - discussion of the reproduction process can happen there.
Done,
Ticket: https://twistedmatrix.com/trac/ticket/8969 <https://twistedmatrix.com/trac/ticket/8969> PR: https://github.com/twisted/twisted/pull/650 <https://github.com/twisted/twisted/pull/650>
Up for review with a guidance request on how to achieve 100% diff coverage given that different platforms behave differently with the same input.
All our supported platforms submit coverage reports; the coverage reported by codecov should be the union of all those reports. So, when your code gets pushed to a branch and run on the buildbots, the coverage report should indicate that. -glyph