Glyph Lefkowitz wrote:
In fact this change actually breaks the Twisted smtp.py code.
Wow. That does look broken. I suggest that if nobody explains this by the end of the day that the change be reverted right away...
Blame spiv.
[0 tv@tao ~/src/twisted/trunk]$ svn log -v -r13494 ------------------------------------------------------------------------ r13494 | spiv | 2005-04-07 17:33:58 +0300 (Thu, 07 Apr 2005) | 1 line Changed paths: M /trunk/twisted/protocols/ftp.py M /trunk/twisted/protocols/policies.py M /trunk/twisted/test/test_ftp.py M /trunk/twisted/test/test_policies.py
Refactor untested connection-limiting from FTP server to twisted.protocols.policies.LimitTotalConnectionsFactory, with tests. ------------------------------------------------------------------------