On Monday, 22 June 2020 08:06:22 BST Glyph wrote:
On Jun 19, 2020, at 4:37 AM, Amber Brown (hawkowl) <hawkowl@atleastfornow.net> wrote:
Hi all,
The past week or so, I noticed failures in the Azure Pipelines CI (see https://github.com/twisted/twisted/pull/1278 for the ticket with them, among others) that were due to Python + Windows falling apart on mgorny's name. ...
Opinions?
I think this is down to a change in Python 3.8 on Windows that defaults opening files to use the Windows code page of the user, like cp1252. My guess is that there is a file being opened without an encoding='utf-8'. (I noticed this with modulefinder and fixed that for python 3.8) Barry
This all sounds like a pretty good plan to me - please go ahead and do it ASAP!
My only concern here is that setting up Twisted services on Windows can already be a bit fiddly, and I would almost rather generate potential mojibake by default than fail to run in a way which would be even harder to debug than it already is. However, even if this is a valid concern, let's not block on it, but figure out a way to fix it after the immediate issue where folks with non-ascii letters in their names can't submit PRs.
Thanks so much for investigating!
-g
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python